-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect management key algorithm used for FIPS in TryChangeManagementKey #162
Fixed incorrect management key algorithm used for FIPS in TryChangeManagementKey #162
Conversation
…lgorithm handling Update management key algorithm refresh • Add FIPS-specific test cases • Enhance test coverage for key changes • Adjust for firmware version differences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, please check my comments.
Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivSession.ManagementKey.cs
Outdated
Show resolved
Hide resolved
Test Results: Windows 2 files 2 suites 4s ⏱️ Results for commit 9de0750. |
Test Results: Ubuntu 2 files 2 suites 10s ⏱️ Results for commit 9de0750. |
Test Results: MacOS 2 files 2 suites 4s ⏱️ Results for commit 9de0750. |
Description
The PivSession.ChangeManagementKey method was incorrectly assuming TripleDes as management key algorithm. This is now fixed.
Fixes: #160
Type of change
How has this been tested?
Had both FIPS and normal 5.7 keys. Ran the TryChangeManagementKey method and reproduced and fixed the bug.
Test configuration:
Normal 5 Multiprotocol, FIPS
Checklist:
dotnet format
to format my codeFootnotes
See Yubikey models (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS) ↩