EXAMPLE: 2.7.0 linting #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.6.1 release
… tweaks to a few other images
… construction code into functions (like createLabelsBox, createNameLabel, etc...)
…and other files into seperate individual files
…ntApis/dataModels
…ntApis/dataModels
…pis package and new dataModels package
…pis package and new dataModels package
Not sure what was going on here, but... We never used the configured Log Level... Why?
The documentation for SdNotify make it very clear that we should be notifying the watchdog at least time/2 (which is to say [WatchdogSec/2]. The primary loop that has done this was `UI.update` although I see that additional calls were added to try to resolve the random reboots. The fact of the matter is, the timer was 10 seconds, and update was only called every 10 seconds... So... A delay of even a second, anywhere in the app, and the watchdog would restart the service. I see where some additional notifys were added, but to be honest, a 10 second timeout seems too short anyway, and cutting it so close was a gamble. So I raised the timeout, and while I did keep the notify in Files (although I did move it to what was really the heavy call), with the additional time, I don't really think it is nessesary. This additional buffer, and adhering to the documented call cadence, should resolve the random reboots (I know 2.7.0 was supposed to resolve these, likely due to the addition of the additional notify calls, however I just had a development board doing nothing reset, so...). Also, there was a Notify Ready in Files. That is reserved for Service Init, so I pulled that out.
Bf/config log level
Increase Watchdog timer per documentation recomendations.
Imp/auto local
…ayed in all error cases
Must be over 1.14 to trigger automatic vendoring for potential linter usage. Should not impact building for JESSIE (testing).
BF: Add SPACE and define keyboard buttons visually.
Bug Fix: CustomControls with multiple command lines and Control/Command Confirm handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a TRUE PR, this is just a tribute. 😉
Example for: #279