Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXAMPLE: 2.7.0 linting #280

Closed
wants to merge 103 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
7ef3c02
Merge pull request #198 from Z-Bolt/2.6.1-dev
JeffB42 Jan 2, 2021
02c9ef4
added octoprint-tentacle.svg and file-gcode.svg, also made some small…
JeffB42 Jan 9, 2021
2294ca9
changed file image to file-gcode.svg
JeffB42 Jan 9, 2021
70d03cf
changed file image to file-gcode.svg
JeffB42 Jan 9, 2021
eb7a437
added abilility to browse files on printer's SD card
JeffB42 Jan 9, 2021
28929f1
moved LocationHistory.go from ui to utils
JeffB42 Jan 9, 2021
14c6989
moved LocationHistory.go from ui to utils
JeffB42 Jan 9, 2021
ac5b0b9
moved FileInformationsByDate into its own file
JeffB42 Jan 9, 2021
fb4bf8b
added ability to browse and print files from SD card
JeffB42 Jan 10, 2021
67c96c6
added CSS to display different background colors for alternating list…
JeffB42 Jan 10, 2021
ac447f2
Break up the Momolith! - separated FileRequest and FileInformation ou…
JeffB42 Jan 10, 2021
d59a196
added thumbnail preview to file browser
JeffB42 Jan 10, 2021
2124897
renamed FileInformation to FileResponse
JeffB42 Jan 10, 2021
5bc295b
added blank.svg for uniform formatting and alignment
JeffB42 Jan 10, 2021
a59f468
added styling and alignment for preview thumbnail
JeffB42 Jan 10, 2021
19d6005
refactored thubnail code into addThumbnail(), refactored duplicate UI…
JeffB42 Jan 10, 2021
79d2794
removed commentdd code and extra whitespace
JeffB42 Jan 10, 2021
5c958ce
fixed printing bug where wrong source locations was being used
JeffB42 Jan 11, 2021
7684f6d
renamed file.go to file_utils.go
JeffB42 Jan 11, 2021
87e029f
added call to GetObfuscatedValue() in dumpObfuscatedEnvironmentVariab…
JeffB42 Jan 11, 2021
bc352f8
more Break up the Monolith! changes, continued to seperate common.go …
JeffB42 Jan 11, 2021
bc465c0
added additional speed dial images
JeffB42 Jan 12, 2021
755470f
added additional speed dial images
JeffB42 Jan 12, 2021
814b2a6
added missing image
JeffB42 Jan 17, 2021
55fcfb2
changed statusMapping to public
JeffB42 Jan 17, 2021
4e16824
hard fork of the mcuadros/go-octoprint code into octoprintApis
JeffB42 Jan 24, 2021
87823da
Hard fork of mcuadros/go-octoprint-moved to octoprintApis and octopri…
JeffB42 Jan 31, 2021
ae057fc
Hard fork of mcuadros/go-octoprint-moved to octoprintApis and octopri…
JeffB42 Jan 31, 2021
b1fae8b
Hard fork of mcuadros/go-octoprint-updated code to use new octoprintA…
JeffB42 Jan 31, 2021
c2ae816
Hard fork of mcuadros/go-octoprint-updated code to use new octoprintA…
JeffB42 Feb 2, 2021
9f08883
changed black background to transparent
JeffB42 Feb 14, 2021
f1b31d5
added new extruder variation
JeffB42 Feb 14, 2021
3123c0a
made entire row in Files list to a button, making it easier to select
JeffB42 Feb 14, 2021
780c9de
chaged border of dialog to make it more noticable
JeffB42 Feb 15, 2021
5ddebef
added file name to print confirmation dialog box
JeffB42 Feb 15, 2021
5f0ae24
added some additional bounds checking to TruncateString()
JeffB42 Feb 15, 2021
7c3bebd
made small design modification to the extruder-typeB images
JeffB42 Feb 16, 2021
21c2bcb
updated version to 2.7.0
JeffB42 Feb 16, 2021
91c41b3
minor format change to open.svg
JeffB42 Feb 16, 2021
9cb31d4
added check to NotificationRequest so it doesn't call the API unless …
JeffB42 Feb 16, 2021
9e486c0
added support for multi-extruder systems, made desctinction beteween …
JeffB42 Feb 16, 2021
56dc6c7
added additional log statements for debugging
JeffB42 Feb 18, 2021
30dc193
added additional log statements for debugging
JeffB42 Feb 18, 2021
380e688
added additional log statements for debugging
JeffB42 Feb 18, 2021
569907e
added StructToJson()
JeffB42 Feb 18, 2021
7cb9d0f
added aditional logging to API calls
JeffB42 Feb 20, 2021
c31fbb4
added HttpRequestTestWindow.go
JeffB42 Feb 20, 2021
508a34b
added import
JeffB42 Feb 21, 2021
e85c06a
broke verifyConnection() up, added getUiStateAndMessageFromConnection…
JeffB42 Feb 21, 2021
2cacaf4
broke verifyConnection() up, added getUiStateAndMessageFromConnection…
JeffB42 Feb 21, 2021
2c3d5e0
added comment about how updateTemperaturesCallback() needs to guard w…
JeffB42 Feb 21, 2021
55960bb
added MISSING_ENV_TOKEN and INVALID_ENV_TOKEN
JeffB42 Feb 21, 2021
0242f95
added more logging to ui.go
JeffB42 Feb 21, 2021
ced239f
added call to sdNotify() to prevent crashing when printer is unplugged
JeffB42 Feb 26, 2021
6d9480c
moved logger into it's own folder/package
JeffB42 Feb 27, 2021
5bd78c7
updated code to use new logger library
JeffB42 Feb 27, 2021
3d57ade
updated code to use new logger library
JeffB42 Feb 27, 2021
a6c5db2
updated the setting of OctoPrintPluginIsAvailable
JeffB42 Feb 27, 2021
b673462
updated comment
JeffB42 Feb 27, 2021
15738ae
fixed typo in comment
JeffB42 Feb 27, 2021
95fe39d
changed a few logging statements from Info to Debug
JeffB42 Feb 28, 2021
80ddee8
fixed comment
JeffB42 Feb 28, 2021
3bb0019
cleaned up code in CreateSelectExtruderStepButton() and CreateSelectH…
JeffB42 Feb 28, 2021
a6247e1
Initial allow CustomControls with multiple command lines. (untested)
thebeline Mar 5, 2021
662f24c
added mutex for _indentation to prevent race condition
JeffB42 Mar 13, 2021
513dacb
fixed bug in SystemCommandsRequest.Do() where Unmarshal() was being p…
JeffB42 Mar 13, 2021
fcf2c9b
seperated out the refreshButton and backButton, added displayRootLoca…
JeffB42 Mar 13, 2021
454f250
added logging to try and catch if the app unexpectedly quits
JeffB42 Mar 13, 2021
edca877
added call to sdRefreshRequest.Do() to refresh the file list when the…
JeffB42 Mar 13, 2021
de81a36
added calls to sdNotify(), refactred into handleRootLocationClick()
JeffB42 Mar 14, 2021
b9a0006
added missing 'this'
JeffB42 Mar 14, 2021
b3f7a7d
reverted click handler b/c it needs 'location'
JeffB42 Mar 14, 2021
3903a52
added 'UI' which was removed
JeffB42 Mar 14, 2021
9483bb5
Chech SD status prior to loading or going back.
thebeline Mar 14, 2021
b85c127
Well shoot.
thebeline Mar 15, 2021
7ee7da6
Debug because... Oddness...
thebeline Mar 15, 2021
4501b8d
Logging?
thebeline Mar 15, 2021
fc972a6
Just trying to figure out where I am...
thebeline Mar 15, 2021
9191d7f
Check the SD state after refresh request.
thebeline Mar 15, 2021
516b47c
Removing unneeded logs.
thebeline Mar 15, 2021
f6adc73
Removing more unneeded logs.
thebeline Mar 15, 2021
3cecb76
Seems like too easy of a fix.
thebeline Mar 16, 2021
1756f56
Increase Watchdog timer per documentation recomendations.
thebeline Mar 16, 2021
fc762a7
Merge pull request #254 from thebeline/BF/ConfigLogLevel
JeffB42 Mar 16, 2021
88015ff
SD Is Ready
thebeline Mar 22, 2021
7abd017
Method names are hard. ;-)
thebeline Mar 22, 2021
9aafdc6
Watchdog everything.
thebeline Mar 22, 2021
d4ef510
Merge pull request #255 from thebeline/BF/WatchDogTimeout
JeffB42 Mar 23, 2021
3e9acf1
Merge pull request #251 from thebeline/IMP/AutoLocal
JeffB42 Mar 23, 2021
a60e1c0
removed extra '*'
JeffB42 Mar 23, 2021
ed7e049
added Panic() and Panicln()
JeffB42 Mar 23, 2021
0728b9d
remved calls to fatal(), reworked code so a FatalErrorWindow is displ…
JeffB42 Mar 24, 2021
3d2913d
XMerge branch '2.7.0-dev' into BF/Commands
thebeline Mar 24, 2021
e1cc6a3
Fixed Command/Control Button Confirm dialog calling.
thebeline Mar 24, 2021
40ac407
Add SPACE and define keyboard buttons visually.
thebeline Mar 24, 2021
f0897cb
Go.Mod stub
thebeline Mar 26, 2021
00e92fe
Merge pull request #265 from thebeline/BF/SSIDPasswordSpace
JeffB42 Mar 27, 2021
8e7822b
Merge pull request #263 from thebeline/BF/Commands
JeffB42 Mar 27, 2021
8bab188
cleaned up CommandButton.handleClicked() and ControlButton.handleClic…
JeffB42 Mar 27, 2021
b6fdb9d
cleaned up CommandButton.handleClicked() and ControlButton.handleClic…
JeffB42 Mar 27, 2021
5141a02
A clean start
thebeline Mar 26, 2021
9f30e78
Merge branch 'IMP/GoModStub' into HEAD
thebeline Mar 29, 2021
46db65a
Merge branch 'IMP/GolangLinter' into 2.7.0-linting
thebeline Mar 29, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: GolangCI Lint
on:
push:
paths:
- '**.go'
tags:
- v*
branches:
- master
- development
pull_request:
paths:
- '**.go'
jobs:
golangci:
name: Lint
runs-on: ubuntu-latest
# This is just temporary, until we upgrade `gotk3` to the latest version
# At this time, with our current version of `gotk3` there are a few bugs with `golang1.16.x`
strategy:
matrix:
go-version: [1.15.x]
steps:
- name: Git Checkout
uses: actions/checkout@v2
- name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends build-essential git-buildpackage fakeroot libcairo2-dev libgtk-3-dev git devscripts gccgo gcc libc-dev
# When we ARE able to use 1.16, this would be how we install `golang1.16.x` AND modify the `go env` (`golangci-lint` doesn't support this natively)
#- name: GolangCI INIT
# uses: golangci/golangci-lint-action@master
- name: Configure Golang ENV
# This ensures that the correct build flags are set for the linters.
# To have this be the ACTUAL installed versions, use
# go env -w GOFLAGS=-tags=gtk_$(pkg-config --modversion gtk+-3.0 | tr -t . _ | cut -d _ -f 1-2),pango_$(pkg-config --modversion pango | tr -t . _ | cut -d _ -f 1-2),gdk_pixbuf_$(pkg-config --modversion gdk-pixbuf-2.0 | tr -t . _ | cut -d _ -f 1-2),glib_$(pkg-config --modversion glib-2.0 | tr -t . _ | cut -d _ -f 1-2)
# I set it to these statics, as these are the statics used in the MakeFile, and are acceptable in leu of setting them to the explicit versions.
# Additionally, the `gtk_3_22` tag must be explicitly set for `golang1.16.x` at this time, as the current `gotk3` package (current `master, not our packaged version) has an issue with `1.16.x`. This may change in the future, will have to run more tests.
run: |
go version
go env -w GOFLAGS=-tags=gtk_3_22,glib_2_58,pango_1_42,gdk_pixbuf_2_38
go env
- name: GolangCI Lint
uses: golangci/golangci-lint-action@master
with:
version: v1.39.0
skip-go-installation: true
only-new-issues: true
# FIXME Only for the time being, we should comment this out once we are comfortable with it.
args: --issues-exit-code 0
Loading