Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncontroversial ChobbyLauncher crash report improvements #2979

Closed
wants to merge 3 commits into from

Commits on Mar 31, 2024

  1. Update Octokit 0.51.0 -> 10.0.0

    Old Octokit versions used int rather than long for Issue.Id;
    which causes overflow error when parsing responses from the GitHub Issues API.
    See octokit/octokit.net#2890
    Mankarse committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    80c8169 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Use a more sophisticated algorithm for CrashReportHelper.Truncate

    This has two benefits
    1) It supports specifying more than one point of interest
       in the interior of the infolog. In a future commit,
       this will be used when an infolog contains more than
       one game with a desync.
    2) It has far superior performance.
    Mankarse committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e3afc3d View commit details
    Browse the repository at this point in the history
  2. Improve parsing of infolog_full.txt

    The new parser identifies regions of the infolog that correspond
    to individual games. Each game is further parsed to find:
      GameID
      FirstDesyncIndex
      GameState file names
    
    If the infolog contains GameState file names,
    include them in a table in the Issue description.
    
    If the infolog contains multiple games with desyncs, try
    to include all of the desync messages in the truncated
    infolog.
    Mankarse committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b98e593 View commit details
    Browse the repository at this point in the history