Uncontroversial ChobbyLauncher crash report improvements #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old Octokit versions used int rather than long for Issue.Id; which causes overflow error when parsing responses from the GitHub Issues API. See octokit/octokit.net#2890
Mankarse
force-pushed
the
Part1
branch
6 times, most recently
from
c621c9f
to
7a17fec
Compare
This has two benefits 1) It supports specifying more than one point of interest in the interior of the infolog. In a future commit, this will be used when an infolog contains more than one game with a desync. 2) It has far superior performance.
The new parser identifies regions of the infolog that correspond to individual games. Each game is further parsed to find: GameID FirstDesyncIndex GameState file names If the infolog contains GameState file names, include them in a table in the Issue description. If the infolog contains multiple games with desyncs, try to include all of the desync messages in the truncated infolog.
Licho1
approved these changes
Apr 3, 2024
Licho1
approved these changes
Apr 6, 2024
|
@Mankarse please update your PR it is out of date. |
|
integrated to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 1-3 from #2978