Magtheridon: Add blast nova counter to addtime

[ForestJ316]

Forgot to include the counter when adding time on P3 transition.

On a side note, apparently some people are having overlapping bars after the latest update? From what I heard Conflag bar and Blast Nova was overlapping, but I didn't have this issue. Maybe you have some more insight into it?

[Zidras]

Add time accepts extra args but only in the case original timer was less than 0.
Can this happen?

[Zidras]

As for the overlap, you mean visually, or mechanic overlap?
If the former, then it's faulty installation (head them over to the faq section of discord)

[ForestJ316]

Add time accepts extra args but only in the case original timer was less than 0. Can this happen?

The timer being less than 0, I don't think so. Since there isn't a keep arg wouldn't it be 0 if the boss just doesn't cast blast nova on timer? At the moment it seemed to be accurate though. I do have an example of how it works without/with the extra arg.

Timer in Phase 2:

Currently going into Phase 3:

Going into Phase 3 with the counter arg:

As for the overlap, you mean visually, or mechanic overlap?
If the former, then it's faulty installation (head them over to the faq section of discord)

From what it sounded it was a visual issue. Okay, I'll let them know.

[Zidras]

Add time accepts extra args but only in the case original timer was less than 0. Can this happen?

The timer being less than 0, I don't think so. Since there isn't a keep arg wouldn't it be 0 if the boss just doesn't cast blast nova on timer? At the moment it seemed to be accurate though. I do have an example of how it works without/with the extra arg.

Timer in Phase 2: Currently going into Phase 3: Going into Phase 3 with the counter arg:

As for the overlap, you mean visually, or mechanic overlap?
If the former, then it's faulty installation (head them over to the faq section of discord)

From what it sounded it was a visual issue. Okay, I'll let them know.

Hmm less then zero is also non existent afaik. But let's say it was 5s left on p2 transition to p3, what would the expected result be?

[ForestJ316]

Blast nova cast would be 23s later as opposed to 5s later, at least based on what I checked so far. Those 3 timers just get +18s added to them as of right now. I would expect that the timer would be updated to reflect this.

[Zidras]

Shouldn't it be this? The timer is for the next Blast Nova, not the current one

Suggested change

	timerBlastNovaCD:AddTime(18, self.vb.blastNovaCounter)
	timerBlastNovaCD:AddTime(18, self.vb.blastNovaCounter+1)

[ForestJ316]

It already gets incremented here.

DBM-Warmane/DBM-Magtheridon/Magtheridon.lua

Lines 50 to 55 in 8eb1de1

	elseif args.spellId == 30616 then
	self.vb.blastNovaCounter = self.vb.blastNovaCounter + 1
	specWarnBlastNova:Show(L.name)
	specWarnBlastNova:Play("kickcast")
	timerBlastNovaCD:Start(nil, self.vb.blastNovaCounter)
	end

It's just adding 18 seconds to the current timer, so whatever the current bar is. The screenshots above should give you a good example of what the bug is currently.

[Zidras]

Ahh you started the counter at 1. that's not really standard practice in dbm, but since you don't use for the warnings, I'll leave it be