Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magtheridon: Add blast nova counter to addtime #221

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Magtheridon: Add blast nova counter to addtime #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DBM-Magtheridon/Magtheridon.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function mod:CHAT_MSG_MONSTER_YELL(msg)
-- +18 to the timers
timerConflagration:AddTime(18)
timerQuake:AddTime(18)
timerBlastNovaCD:AddTime(18)
timerBlastNovaCD:AddTime(18, self.vb.blastNovaCounter)
Copy link
Owner

@Zidras Zidras Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be this? The timer is for the next Blast Nova, not the current one

Suggested change
timerBlastNovaCD:AddTime(18, self.vb.blastNovaCounter)
timerBlastNovaCD:AddTime(18, self.vb.blastNovaCounter+1)

Copy link
Contributor Author

@ForestJ316 ForestJ316 Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already gets incremented here.

DBM-Warmane/DBM-Magtheridon/Magtheridon.lua

Lines 50 to 55 in 8eb1de1

elseif args.spellId == 30616 then
self.vb.blastNovaCounter = self.vb.blastNovaCounter + 1
specWarnBlastNova:Show(L.name)
specWarnBlastNova:Play("kickcast")
timerBlastNovaCD:Start(nil, self.vb.blastNovaCounter)
end

It's just adding 18 seconds to the current timer, so whatever the current bar is. The screenshots above should give you a good example of what the bug is currently.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh you started the counter at 1. that's not really standard practice in dbm, but since you don't use for the warnings, I'll leave it be

timerDebris:Start()
end
end
Expand Down
Loading