Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tagging ISO structures #136

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Fix tagging ISO structures #136

merged 13 commits into from
Sep 26, 2024

Conversation

nodh
Copy link
Contributor

@nodh nodh commented Sep 25, 2024

Resolves #116

@nodh nodh self-assigned this Sep 25, 2024
@nodh nodh mentioned this pull request Sep 25, 2024
Merged
JesusMcCloud
JesusMcCloud reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks very clean!

vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/Validator.kt Show resolved Hide resolved
@nodh nodh added this to the 5.0 milestone Sep 26, 2024
JesusMcCloud
JesusMcCloud approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! pending tests

@nodh nodh merged commit ebd71fe into develop Sep 26, 2024
4 checks passed
@nodh nodh deleted the feature/iso-tag-24 branch September 26, 2024 10:03
@nodh nodh mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMcCloud JesusMcCloud JesusMcCloud approved these changes

Assignees

@nodh nodh

Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nodh @JesusMcCloud