-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(benches): Fixes compiler errors for benches #416
Conversation
We fix compiler errors that we see while running tests and benchmarking.
A few runtime errors that are still to be fixed, which I wanted some feedback on - Tests: I see these tests failing - They fail because the Benchmarks:
|
Believe @0xRampey is also working on the compiler errors within tests. Since he found the issue first, we should merge his PR in. I'll reshape this PR to target the |
Turns out that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We fix compiler errors that we see while benchmarking.