-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Adding dicom upload #6161
Conversation
[instrument_manager] Modularize instrument manager (aces#3185)
minor 2017-11-20
adding OPTIONS requests handling
…Loris into api-module-candidates-and-subs
Co-Authored-By: xlecours <[email protected]>
Co-Authored-By: xlecours <[email protected]>
I am waiting for #6671 to get merged so I can add tests |
This needs to go in a 0.0.4-dev, not 0.0.3 |
@xlecours could you rebase your branch? |
@xlecours I rebased this for you here https://github.com/ridz1208/Loris/tree/adding_dicom_upload if you want I can force push to your branch or you can simply pull it and force push it yourself. |
This is missing integration tests. @xlecours |
@cmadjar can you review? |
@xlecours are you referring to yourself in the third person? Who's supposed to be writing tests? |
Yes, I am. |
Replaced by #9154 |
Copy of #5016
This adds
POST /candidates/<candid>/<visit>/dicoms
to upload a dicom.GET /candidates/<candid>/<visit>/dicoms/<filename>/processes
to get the server processes related to that dicom upload (mri_upload)POST /candidates/<candid>/<visit>/dicoms/<filename>/processes
to start a mri_upload server process on that dicom.GET /candidates/<candid>/<visit>/dicoms/<filename>/processes/<processid>
to get the state of a processThis work is based on #4244
To see this PR changes go to xlecours/Loris@api-module-candidates-and-subs...xlecours:adding_dicom_upload
TODO: