Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable huggingface tests on MacOS #2651

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

nvoxland
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Build change

Description

An incompatibility between pyarrow and libdeeplake with the AWS client is causing the macos build to fail. Pyarrow gets used in the huggingface integration only, so disabled those tests on macos to avoid the failure.

@nvoxland nvoxland added the test-macos Trigger MacOS tests label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dfa2c2b) 84.31% compared to head (d35aab2) 83.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2651      +/-   ##
==========================================
- Coverage   84.31%   83.73%   -0.58%     
==========================================
  Files         229      229              
  Lines       25509    25509              
==========================================
- Hits        21507    21360     -147     
- Misses       4002     4149     +147     
Flag Coverage Δ
unittests 83.73% <ø> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nvoxland nvoxland added the full-tests Trigger Full versioned OS tests label Oct 12, 2023
@nvoxland nvoxland marked this pull request as draft November 2, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-tests Trigger Full versioned OS tests test-macos Trigger MacOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant