Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable huggingface tests on MacOS #2651

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Disable huggingface tests on MacOS #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ac4482
Disable huggingface tests on macos because they cause pyarrow incompa…
nvoxland Oct 11, 2023
d35aab2
Fixed test-macos label for github action
nvoxland Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
]
}

if "${{ contains(github.event.pull_request.labels.*.name, 'macos-tests') }}" == "true":
if "${{ contains(github.event.pull_request.labels.*.name, 'test-macos') }}" == "true":
matrix["os"].append("macos-latest")

if "${{ contains(github.event.pull_request.labels.*.name, 'full-tests') }}" == "true":
Expand Down
10 changes: 9 additions & 1 deletion deeplake/integrations/tests/test_huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
import pytest
import sys

if sys.platform == "darwin":
pytest.skip(
"skipping tests on macos due to issue with pyarrow + our aws usage https://github.com/aws/aws-sdk-cpp/issues/2411",
allow_module_level=True,
)

from datasets import load_dataset # type: ignore
from datasets import Dataset # type: ignore
from deeplake.api.tests.test_api import convert_string_to_pathlib_if_needed
Expand All @@ -6,7 +15,6 @@
from deeplake.util.exceptions import TensorAlreadyExistsError
from numpy.testing import assert_array_equal

import pytest
import deeplake


Expand Down
Loading