-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn instead of throwing when parsing invalid WKT POINT
s
#1525
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 88.14% 88.21% +0.06%
==========================================
Files 359 361 +2
Lines 27013 27117 +104
Branches 3649 3663 +14
==========================================
+ Hits 23810 23920 +110
+ Misses 1955 1953 -2
+ Partials 1248 1244 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much.
There is an opportunity for cleanup here, but otherwise thanks for the quick fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small nitpicks, mostly to make you aware of useful features in the STL.
Co-authored-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, I will wait for the checks and then merge this.
Quality Gate passedIssues Measures |
If the RDF parser encounters an invalid POINT (e.g. because it's coordinates are out of range), it will now convert it to a plain string literal without datatype. This behavior is consistent with the one for invalid
Date
values.