Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of throwing when parsing invalid WKT POINTs #1525

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

ullingerc
Copy link
Collaborator

@ullingerc ullingerc commented Sep 30, 2024

If the RDF parser encounters an invalid POINT (e.g. because it's coordinates are out of range), it will now convert it to a plain string literal without datatype. This behavior is consistent with the one for invalid Date values.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (2e0ac35) to head (896ad5b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
+ Coverage   88.14%   88.21%   +0.06%     
==========================================
  Files         359      361       +2     
  Lines       27013    27117     +104     
  Branches     3649     3663      +14     
==========================================
+ Hits        23810    23920     +110     
+ Misses       1955     1953       -2     
+ Partials     1248     1244       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.
There is an opportunity for cleanup here, but otherwise thanks for the quick fix.

src/parser/RdfParser.cpp Outdated Show resolved Hide resolved
@ullingerc ullingerc requested a review from joka921 September 30, 2024 14:44
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small nitpicks, mostly to make you aware of useful features in the STL.

src/parser/RdfParser.cpp Outdated Show resolved Hide resolved
src/parser/RdfParser.cpp Outdated Show resolved Hide resolved
@ullingerc ullingerc requested a review from joka921 October 1, 2024 07:10
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I will wait for the checks and then merge this.

Copy link

sonarqubecloud bot commented Oct 4, 2024

@joka921 joka921 merged commit 060bd89 into ad-freiburg:master Oct 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants