Alternative GHA structure for nf-core/modules #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrtalbot
force-pushed
the
new_gha_set_up
branch
from
c3c8595
to
c194267
Compare
Co-authored-by: Harshil Patel <[email protected]>
Co-authored-by: Harshil Patel <[email protected]>
…red to lint before running. This will help us during hackathons etc when there is a high burden on the GHA runners, but will be slower in general use. Changes: - linting and testing in one GHA file - Linting is required to pass before pytest or nf-test runs - Check for changes only happens once
adamrtalbot
force-pushed
the
new_gha_set_up
branch
from
6715cb1
to
571e685
Compare
This reverts commit f050865.
adamrtalbot
pushed a commit
that referenced
this pull request
Apr 5, 2024
* Added metaphlan subworkflow * Removed extra index line * Added config * Updated meta.yml, removed comments * Apply suggestions from code review Co-authored-by: Carson J Miller <[email protected]> * Updated test snapshot * Updated test snapshot #2 * Apply suggestions from code review * Sort output by file name * Changed sort; modified test dataset used * Changed sort method to file name --------- Co-authored-by: Carson J Miller <[email protected]> Co-authored-by: Maxime U Garcia <[email protected]> Co-authored-by: Carson J Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New GHA set up. This runs the tests in linear so no tests are run unless linting passes etc. The order is:
Concurrently with 2, 3 and 4:
2. Check for changes (nf-test)
3. nf-test
I wanted to combine nf-test and pytest into one workflow but I couldn't do it with the existing path filters, this is a future objective. We can possibly add an
nf-testtag which includes/excludes but I wasn't able to get it working right now.