Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative GHA structure for nf-core/modules #2

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Alternative GHA structure for nf-core/modules #2

wants to merge 34 commits into from

Commits on Jul 28, 2023

  1. Add wait-for-status workflow

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2a91bc1 View commit details
    Browse the repository at this point in the history

  2. Rename and tidy all GHA workflows for branch protection

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    888d820 View commit details
    Browse the repository at this point in the history

  3. Changing some stuff to kick off real CI/CD

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d92ca5c View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Harshil Patel <[email protected]>
    @adamrtalbot @drpatelh
    adamrtalbot and drpatelh committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ae773bd View commit details
    Browse the repository at this point in the history

  5. Update .github/workflows/code-linting.yml 

    Co-authored-by: Harshil Patel <[email protected]>
    @adamrtalbot @drpatelh
    adamrtalbot and drpatelh committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e4cba90 View commit details
    Browse the repository at this point in the history

  6. Should reduce concurrent burden at the expense of time. Code is requi… 

    …red to lint before running. This will help us during hackathons etc when there is a high burden on the GHA runners, but will be slower in general use.

Changes:
 - linting and testing in one GHA file
 - Linting is required to pass before pytest or nf-test runs
 - Check for changes only happens once
    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    ce5579d View commit details
    Browse the repository at this point in the history

  7. Fix dependencies in GHA

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0b05e07 View commit details
    Browse the repository at this point in the history

  8. Remove files again

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a651f01 View commit details
    Browse the repository at this point in the history

  9. More dependency fixes

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b454fb9 View commit details
    Browse the repository at this point in the history

  10. Correct nf-test filtering yaml

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    a10564d View commit details
    Browse the repository at this point in the history

  11. Change to fix-linting for consistency

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    49fb85d View commit details
    Browse the repository at this point in the history

  12. Bump setup-python version to v4

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    571e685 View commit details
    Browse the repository at this point in the history

  13. bump eWaterCycle/setup-singularity to v7

    @adamrtalbot
    adamrtalbot committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    79a73a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Add final job to test for pass status of all previous jobs

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3a8b0a0 View commit details
    Browse the repository at this point in the history

  2. Add checking for changes to test requirement

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    07e940c View commit details
    Browse the repository at this point in the history

  3. Revert module changes

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f490974 View commit details
    Browse the repository at this point in the history

  4. Add fake change to FASTQC

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f050865 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into new_gha_set_up

    @adamrtalbot
    adamrtalbot authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    883cc31 View commit details
    Browse the repository at this point in the history

  6. Test in parallel

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    27385df View commit details
    Browse the repository at this point in the history

  7. Revert "Add fake change to FASTQC" 

    This reverts commit f050865.
    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d3c9b76 View commit details
    Browse the repository at this point in the history

  8. Change logic to allow skipped processes

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    269c63f View commit details
    Browse the repository at this point in the history

  9. Format changes

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    da0a03d View commit details
    Browse the repository at this point in the history

  10. Change logic again

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    83fec8c View commit details
    Browse the repository at this point in the history

  11. Change logic again

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4b2c0f7 View commit details
    Browse the repository at this point in the history

  12. Change logic again

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    01ef2f4 View commit details
    Browse the repository at this point in the history

  13. Add debug step to help work it out

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    62d1702 View commit details
    Browse the repository at this point in the history

  14. Caught pytest-changes bug

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b2003b0 View commit details
    Browse the repository at this point in the history

  15. Reintroduce change to FASTQC module

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    197ffeb View commit details
    Browse the repository at this point in the history

  16. Remove debug statements

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d75f94b View commit details
    Browse the repository at this point in the history

  17. Revert "Reintroduce change to FASTQC module" 

    This reverts commit 197ffeb.
    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a153d53 View commit details
    Browse the repository at this point in the history

  18. Mess up FASTQC deliberately to test failures

    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c28fef4 View commit details
    Browse the repository at this point in the history

  19. Revert "Mess up FASTQC deliberately to test failures" 

    This reverts commit c28fef4.
    @adamrtalbot
    adamrtalbot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4f7c9ac View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Changed to all lower case

    @adamrtalbot
    adamrtalbot committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    60ca551 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into new_gha_set_up

    @adamrtalbot
    adamrtalbot authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e142092 View commit details
    Browse the repository at this point in the history