Fix sizing of breadcrumbs to make breadcrumbs size appropriate #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solimant
force-pushed
the
breadcrumbsFix
branch
2 times, most recently
from
11d8928 to
1d9dc96
Compare
solimant
reviewed
May 13, 2022
There was a problem hiding this comment.
Do you think this is an opportunity to actually switch to the RSP v3 Breadcrumbs component? It's a little bit cumbersome having to deal with SVG paths and stuff, I think.
@solimant I think this is a great idea! Will update the PR accordingly |
solimant
approved these changes
May 16, 2022
| </ul> | ||
| </nav> | ||
| ) | ||
| const ParliamentBreadcrumbs = ({ breadcrumbsPages, ...props }) => { |
There was a problem hiding this comment.
Now that we've moved to using v3 Breadcrumbs, I'm not sure if having this component here is providing any value. I think we should deprecate it:
Suggested change
| const ParliamentBreadcrumbs = ({ breadcrumbsPages, ...props }) => { | |
| /** | |
| * Parliament Breadcrumbs are deprecated. Please use the React Spectrum v3 Breadcrumbs instead. | |
| * See the docs for details: https://react-spectrum.adobe.com/react-spectrum/Breadcrumbs.html. | |
| * | |
| * @deprecated | |
| */ | |
| const ParliamentBreadcrumbs = ({ breadcrumbsPages, ...props }) => { | |
| console.warn('Parliament Breadcrumbs are deprecated. Please use the React Spectrum v3 Breadcrumbs instead. See the docs for details: https://react-spectrum.adobe.com/react-spectrum/Breadcrumbs.html'); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spectrum-CSS uses an alias value that is undetected by Parliament UI library, which causes no
heightandwidthto be set for the chevron icons. This change enforces the chevrons to be a certain height and width.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Before
After
Types of changes
Checklist: