Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizing of breadcrumbs to make breadcrumbs size appropriate #189

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix sizing of breadcrumbs to make breadcrumbs size appropriate #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d9dc96
Fix spacing for breadcrumbs
Apr 27, 2022
f50be16
Convert v2 breadcrumbs to v3
May 16, 2022
d01a0f9
Add deprecation warning
May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@adobe/parliament-ui-components",
"version": "5.2.2",
"version": "5.2.3",
"description": "UI Components for Parliament projects",
"author": {
"name": "Simon Mac Donald",
Expand Down
13 changes: 10 additions & 3 deletions src/Breadcrumbs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,13 @@ const Breadcrumbs = ({ selectedTopPage, selectedSubPages, ...props }) => (
{selectedTopPage?.title}
</GatsbyLink>
<svg
andrewchough marked this conversation as resolved.
Show resolved Hide resolved
className='spectrum-Icon spectrum-UIIcon-ChevronRightSmall spectrum-Breadcrumbs-itemSeparator'
className='spectrum-Icon spectrum-Breadcrumbs-itemSeparator'
focusable='false'
role='img'
aria-hidden='true'
css={css`
width: var(--spectrum-global-dimension-size-75);
height: var(--spectrum-global-dimension-size-100);
`}
>
<path
d='M7 5a.747.747 0 00-.22-.53L2.54.23a.75.75 0 10-1.06 1.06L5.19 5 1.48 8.71a.75.75 0 101.06 1.06l4.24-4.24A.747.747 0 007 5z'
Expand All @@ -57,10 +60,14 @@ const Breadcrumbs = ({ selectedTopPage, selectedSubPages, ...props }) => (
{page.title}
</GatsbyLink>
<svg
className='spectrum-Icon spectrum-UIIcon-ChevronRightSmall spectrum-Breadcrumbs-itemSeparator'
className='spectrum-Icon spectrum-Breadcrumbs-itemSeparator'
focusable='false'
role='img'
aria-hidden='true'
css={css`
width: var(--spectrum-global-dimension-size-75);
height: var(--spectrum-global-dimension-size-100);
`}
>
<path
d='M7 5a.747.747 0 00-.22-.53L2.54.23a.75.75 0 10-1.06 1.06L5.19 5 1.48 8.71a.75.75 0 101.06 1.06l4.24-4.24A.747.747 0 007 5z'
Expand Down