-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-143783 - [Marquee] block enhancement - Support for logo | label 'lockup' #2192
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2192 +/- ##
==========================================
- Coverage 95.71% 95.69% -0.03%
==========================================
Files 166 166
Lines 44007 44009 +2
==========================================
- Hits 42122 42115 -7
- Misses 1885 1894 +9 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-143783
@ryanmparrish there seems to be some failing nala tests, could you look into them? |
In Milo I want to be able to author a logo | label 'lockup' in the marquee and have it looks great in all offered variants and authoring usages.
Resolves: MWPW-143783
Draft URLs:
Libs URLs:
Live BACOM pages: