Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-143783 - [Marquee] block enhancement - Support for logo | label 'lockup' #2192

Merged
merged 11 commits into from
May 8, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Apr 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Apr 23, 2024

@ryanmparrish ryanmparrish added the needs-verification PR requires E2E testing by a reviewer label Apr 23, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to rparrish/marquee-lockup April 23, 2024 22:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rparrish/marquee-lockup April 23, 2024 22:34 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rparrish/marquee-lockup April 23, 2024 23:19 Inactive
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (5dc834c) to head (c016079).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2192      +/-   ##
==========================================
- Coverage   95.71%   95.69%   -0.03%     
==========================================
  Files         166      166              
  Lines       44007    44009       +2     
==========================================
- Hits        42122    42115       -7     
- Misses       1885     1894       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skumar09 skumar09 added the run-nala Run Nala Test Automation against PR label Apr 24, 2024
@ryanmparrish ryanmparrish marked this pull request as ready for review April 24, 2024 14:24
@skumar09 skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Apr 24, 2024
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@aem-code-sync aem-code-sync bot temporarily deployed to rparrish/marquee-lockup May 7, 2024 15:56 Inactive
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SilviuLCF SilviuLCF added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels May 8, 2024
@mokimo
Copy link
Contributor

mokimo commented May 8, 2024

@ryanmparrish there seems to be some failing nala tests, could you look into them?

@milo-pr-merge milo-pr-merge bot merged commit 5533f4d into stage May 8, 2024
12 checks passed
@milo-pr-merge milo-pr-merge bot deleted the rparrish/marquee-lockup branch May 8, 2024 10:08
@mokimo mokimo mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants