Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-156749: Fix video CLS #2849

Merged
merged 14 commits into from
Sep 17, 2024
Merged

MWPW-156749: Fix video CLS #2849

merged 14 commits into from
Sep 17, 2024

Commits on Sep 5, 2024

  1. MWPW-155412: Fix video CLS netting +10 lighthouse points (adobecom#2724) 

    * fix cls by adding the videoEl without a source

* adapt the video hover and in view port play

* Remove no-lazy and return earlier

* Fix linting issue

* Consolidate duplicated logic

* Move functions into the init function

* Move root margin and use optional chaining

* Only query for the videoEl once
    @mokimo
    mokimo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b382710 View commit details
    Browse the repository at this point in the history

  2. Add default hash at in the right spot

    @mokimo
    mokimo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    38f68ed View commit details
    Browse the repository at this point in the history

  3. Fix the figure/video interaction

    @mokimo
    mokimo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ac12fbb View commit details
    Browse the repository at this point in the history

  4. Remove unused export statement

    @mokimo
    mokimo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d7e2f6d View commit details
    Browse the repository at this point in the history

  5. Keep the previous defaults

    @mokimo
    mokimo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c188d1c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Re-add adding autoplay

    @mokimo
    mokimo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bf367ad View commit details
    Browse the repository at this point in the history

  2. Retain decorateBlockBg logic

    @mokimo
    mokimo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    253feca View commit details
    Browse the repository at this point in the history

  3. Move autoplay logic to the right location

    @mokimo
    mokimo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ff57508 View commit details
    Browse the repository at this point in the history

  4. Fix linting issues

    @mokimo
    mokimo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    dc418ae View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Adapt figure tests

    @mokimo
    mokimo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    64a9120 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. PR Feedback

    @mokimo
    mokimo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7bd8cec View commit details
    Browse the repository at this point in the history

  2. Safeguard decorateAnchorVideo

    @mokimo
    mokimo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    eee2c90 View commit details
    Browse the repository at this point in the history

  3. Remove anchor if neccessary

    @mokimo
    mokimo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    79019d9 View commit details
    Browse the repository at this point in the history

  4. Add video test

    @mokimo
    mokimo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bea6b25 View commit details
    Browse the repository at this point in the history