-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-156749: Fix video CLS #2849
Conversation
* fix cls by adding the videoEl without a source * adapt the video hover and in view port play * Remove no-lazy and return earlier * Fix linting issue * Consolidate duplicated logic * Move functions into the init function * Move root margin and use optional chaining * Only query for the videoEl once
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2849 +/- ##
==========================================
+ Coverage 95.89% 96.25% +0.36%
==========================================
Files 173 238 +65
Lines 46316 54296 +7980
==========================================
+ Hits 44415 52265 +7850
- Misses 1901 2031 +130 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Reminder to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-156749
Original PR: #2724
Resolves: MWPW-156749
Test URLs:
Onhover play
Onviewport play
Only desktop (mobile should not load the video for perf reasons)
CLS
Bacom tests