MWPW-157965: Upgrade Universal Nav to Version 1.3 #2867
Conversation
nishantka
requested review from
salonijain3,
bandana147,
sharmrj,
Deva309 and
sonawanesnehal3
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2867 +/- ##
==========================================
+ Coverage 96.09% 96.18% +0.08%
==========================================
Files 215 215
Lines 53954 53989 +35
==========================================
+ Hits 51849 51929 +80
+ Misses 2105 2060 -45 ☔ View full report in Codecov by Sentry. |
nishantka
added
run-nala
| @@ -608,9 +608,6 @@ class Gnav { | |||
| locale, | |||
| imsClientId: window.adobeid?.client_id, | |||
| theme: isDarkMode() ? 'dark' : 'light', | |||
| onReady: () => { | |||
| this.decorateAppPrompt({ getAnchorState: () => window.UniversalNav.getComponent?.('app-switcher') }); | |||
| }, | |||
There was a problem hiding this comment.
Is onReady callback removed in new version?
There was a problem hiding this comment.
As mentioned in PR description - Unav suggested to not rely on onReady
There was a problem hiding this comment.
and this is true for 1.2 as well? (should someone want to use that version)
There was a problem hiding this comment.
i don't think it affects 1.2 as the window.UNav() promise came up with 1.3
| @@ -608,9 +608,6 @@ class Gnav { | |||
| locale, | |||
| imsClientId: window.adobeid?.client_id, | |||
| theme: isDarkMode() ? 'dark' : 'light', | |||
| onReady: () => { | |||
| this.decorateAppPrompt({ getAnchorState: () => window.UniversalNav.getComponent?.('app-switcher') }); | |||
| }, | |||
There was a problem hiding this comment.
and this is true for 1.2 as well? (should someone want to use that version)
| window.UniversalNav.reload(CONFIG.universalNav.universalNavConfig); | ||
| }); | ||
| window.UniversalNav(CONFIG.universalNav.universalNavConfig) | ||
| .then(() => { |
There was a problem hiding this comment.
Super minor, but I wonder if this won't be clearer with an await instead of a .then. That way we we get less nesting.
There was a problem hiding this comment.
sure. I've updated this to await
|
This PR is currently in the |
|
Verified the Unav 1.3 files and libs are loading in the given branch URL. Complete regression will be done across milo locales pages once PR merge to STAGE.
|
sigadamvenkata
added
verified
Upgrades the UNav to 1.3
Adding eventListener for reloading Unav once Unav promise resolved as with v1.3 - the window.UniversalNav() returns a promise post which we can use methods like window.UniversalNav().reload() - ref
Also, Unav suggested to not rely on onReady method for triggering PEP modal instead we can wait for promise returned by
window.UniversalNav()to be resolved.Resolves: MWPW-157965
Test URLs: