[Release] Stage to Main #2893
Merged
[Release] Stage to Main #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724) * fix cls by adding the videoEl without a source * adapt the video hover and in view port play * Remove no-lazy and return earlier * Fix linting issue * Consolidate duplicated logic * Move functions into the init function * Move root margin and use optional chaining * Only query for the videoEl once * Add default hash at in the right spot * Fix the figure/video interaction * Remove unused export statement * Keep the previous defaults * Re-add adding autoplay * Retain decorateBlockBg logic * Move autoplay logic to the right location * Fix linting issues * Adapt figure tests * PR Feedback * Safeguard decorateAnchorVideo * Remove anchor if neccessary * Add video test
… using a `full-width` variant (#2861) * stub no-min-height * fixed hero has-bg logic
* Upgrade UNav to 1.3 * using await instead of then
* MWPW-158462 [MEP] any-marquee-section simplified selector * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be (#2886) * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be * unit test repair * unit test repair * MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2887) * working so far * lint update * update something merging stage did not
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3 and
a team
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
==========================================
+ Coverage 96.23% 96.24% +0.01%
==========================================
Files 237 237
Lines 54242 54219 -23
==========================================
- Hits 52198 52182 -16
+ Misses 2044 2037 -7 ☔ View full report in Codecov by Sentry. |
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
…2888) Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
|
I saw some error on this page, https://blog.stage.adobe.com/ who can take a look? |
Dli3
approved these changes
Sep 17, 2024
Roycethan
approved these changes
Sep 17, 2024
Roycethan
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
JackySun9
approved these changes
Sep 18, 2024
JackySun9
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
sigadamvenkata
approved these changes
Sep 18, 2024
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
mokimo
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-min-heightand no l/r padding when using afull-widthvariant #2861common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: