Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REVERT MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target #2844 #2870

Merged
merged 1 commit into from
Sep 11, 2024
Merged

REVERT MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target #2844 #2870

merged 1 commit into from
Sep 11, 2024

Conversation

vgoodric
Copy link
Contributor

@vgoodric vgoodric requested a review from a team as a code owner September 11, 2024 19:17
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@vgoodric vgoodric requested a review from a team September 11, 2024 19:17
@vgoodric vgoodric added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Sep 11, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 11, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (c710753) to head (b153c22).
Report is 1 commits behind head on stage.

Additional details and impacted files 
@@           Coverage Diff           @@
##            stage    #2870   +/-   ##
=======================================
  Coverage   96.17%   96.18%           
=======================================
  Files         215      215           
  Lines       53992    53994    +2     
=======================================
+ Hits        51928    51934    +6     
+ Misses       2064     2060    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markpadbe markpadbe self-requested a review September 11, 2024 19:20
@vgoodric vgoodric added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 11, 2024
@mokimo mokimo merged commit 3679fd0 into stage Sep 11, 2024
25 checks passed
@mokimo mokimo deleted the revertspoofpznexperience branch September 11, 2024 19:39
@mokimo mokimo mentioned this pull request Sep 11, 2024
Merged
yesil pushed a commit that referenced this pull request Sep 18, 2024
@vgoodric @yesil
REVERT MWPW-157686 [MEP] Cannot spoof an experience that exists in ma…
6be96bd 
…nifest but not in Target #2844  (#2870)

revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpadbe markpadbe markpadbe approved these changes

@AdobeLinhart AdobeLinhart AdobeLinhart approved these changes

@ivanvatadobe ivanvatadobe ivanvatadobe approved these changes

Assignees
No one assigned
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vgoodric @markpadbe @AdobeLinhart @ivanvatadobe @mokimo