Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2893

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[Release] Stage to Main #2893

merged 5 commits into from
Sep 18, 2024

Commits on Sep 17, 2024

  1. MWPW-156749: Fix video CLS (#2849) 

    * MWPW-155412: Fix video CLS netting +10 lighthouse points (#2724)

* fix cls by adding the videoEl without a source

* adapt the video hover and in view port play

* Remove no-lazy and return earlier

* Fix linting issue

* Consolidate duplicated logic

* Move functions into the init function

* Move root margin and use optional chaining

* Only query for the videoEl once

* Add default hash at in the right spot

* Fix the figure/video interaction

* Remove unused export statement

* Keep the previous defaults

* Re-add adding autoplay

* Retain decorateBlockBg logic

* Move autoplay logic to the right location

* Fix linting issues

* Adapt figure tests

* PR Feedback

* Safeguard decorateAnchorVideo

* Remove anchor if neccessary

* Add video test
    @mokimo
    mokimo authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d4134c8 View commit details
    Browse the repository at this point in the history

  2. MWPW-157888 - Hero marquee w/ no-min-height and no l/r padding when… 

    … using a `full-width` variant (#2861)

* stub no-min-height

* fixed hero has-bg logic
    @ryanmparrish
    ryanmparrish authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eb788ce View commit details
    Browse the repository at this point in the history

  3. MWPW-157965: Upgrade Universal Nav to Version 1.3 (#2867) 

    * Upgrade UNav to 1.3

* using await instead of then
    @nishantka
    nishantka authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d51b989 View commit details
    Browse the repository at this point in the history

  4. MWPW-158462 [MEP] any-marquee-section simplified selector (#2884) 

    * MWPW-158462 [MEP] any-marquee-section simplified selector

* unit test update

* MWPW-158475 [MEP] classes that end in a number are modified when they should not be (#2886)

* unit test update

* MWPW-158475 [MEP] classes that end in a number are modified when they should not be

* unit test repair

* unit test repair

* MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2887)

* working so far

* lint update

* update something merging stage did not
    @vgoodric
    vgoodric authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8da3683 View commit details
    Browse the repository at this point in the history

  5. MWPW-158353: Updates configurator label to Carousel Animation Style (#… 

    …2888)

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
    @cmiqueo @milo-pr-merge
    cmiqueo and milo-pr-merge[bot] authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9323f28 View commit details
    Browse the repository at this point in the history