[MWPW-153363] Countdown Timer implementation based on page metadata #2928
+394
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rahulgupta999
added
run-nala
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #2928 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 236 237 +1
Lines 54278 54421 +143
==========================================
+ Hits 52241 52375 +134
- Misses 2037 2046 +9 ☔ View full report in Codecov by Sentry. |
rahulgupta999
requested review from
ryanmparrish,
Sartxi,
auniverseaway and
a team
as code owners
|
I am waiting for access to promotions sheets to test this PR. For now, I have tested using injection. |
rahulgupta999
changed the title
rahulgupta999
added
the
high priority
Sartxi
approved these changes
Sep 20, 2024
npeltier
requested changes
Sep 20, 2024
npeltier
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As presented in AST, the regions have been using a ticker/timer/countdown visual to boost click-through rates and engagement as an enticement for certain promotions; e.g., Black Friday / Cyber Monday
Countdown Timer (CDT)
Properties:
Resolves: MWPW-153363
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/rahulgup/marquee-parent?martech=off
After: https://cdt-metatag--milo--rahulgupta999.hlx.page/drafts/rahulgup/marquee-parent?martech=off
This has the following authoring dependencies
New Placeholder texts are to be added in the placeholder file
{{cdt-ends-in}}
{{cdt-days}}
{{cdt-hours}}
{{cdt-mins}}
additionally, the following metadata should be present on the page
<meta name="countdown-timer" content="2024-08-26 12:00:00 PST,2024-09-30 00:00:00 PST">I do not have access to promotions sheet to add metadata.