Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-153363] Countdown Timer implementation based on page metadata #2928
[MWPW-153363] Countdown Timer implementation based on page metadata #2928
Changes from all commits
60ee7dc
b675101
0eb2417
9eea2ee
6274f78
2186a05
4ab0ebb
dd5fa31
ee7a296
2a9199d
cebadd6
f7734c8
85cae8c
61733c9
6a73f13
ad9149e
5557a80
5eb6519
4b93016
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing, can you add a test example of a marquee with both
mnemonic-list
&countdown-timer
to ensure this faster implementation also doesn't break anything?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about RTL support ? In RTL there's currently no space between text and timer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why always remove the countdown ? Can you not just update the timer label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value gets cached and will not work when rotating screens. You need to refactor this to always see if the viewport matches the width.
Example: