Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: add checksums for ant and ant-contrib everywhere #2280

Merged
merged 3 commits into from
Sep 30, 2021
Merged

unixPB: add checksums for ant and ant-contrib everywhere #2280

merged 3 commits into from
Sep 30, 2021

Conversation

jeffalder
Copy link
Contributor

Fixes #1954

SHA-512 for ant-1.10.5 was downloaded from the same site; I was not immediately able to identify a secondary trusted source.

changed -c to --check because longer options serve as better self-documentation.
added --strict because otherwise sha512sum will silently ignore malformatted lines (seems suboptimal, but ok)

Checklist
  • commit message has one of the standard prefixes
  • n/a FAQ.md updated if appropriate
  • n/a other documentation is changed or added (if applicable)
  • n/a playbook changes run through VPC or QPC (if you have access)
  • n/a for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@jeffalder
Copy link
Contributor Author

Oh yeah - I built all the docker images locally.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment in the other PR the --check on sha512sum doesn't appear to work on Alpine (checked Alpine 313 in this PR)

Step 8/20 : RUN sha512sum --check --strict /tmp/ant.sha512
 ---> Running in 5e073c0b5769
sha512sum: unrecognized option: check
BusyBox v1.32.1 () multi-call binary.

@jeffalder
Copy link
Contributor Author

@sxa Thanks for looking; I'll fix this up. It's disappointing that the busy-box version is so limited.

@jeffalder
Copy link
Contributor Author

@sxa reverted those changes in 7c9a48f. Also merged master.

@sxa
Copy link
Member

sxa commented Sep 22, 2021

@jeffalder
Copy link
Contributor Author

@sxa looks like the check failed on some platforms, not sure where to go from here.

@jeffalder
Copy link
Contributor Author

I've lost interest in continuing this, I'm going to close it.

@jeffalder jeffalder closed this Sep 28, 2021
@sxa
Copy link
Member

sxa commented Sep 28, 2021

None of the failures in my VPC run is related to this PR (although they need to be resolved separately), so I'm personally ocmfortable with merging it at this point. Sorry you've found this a bit disheartening and I hope it won't put you off contributing in the future :-)

@sxa sxa reopened this Sep 30, 2021
@sxa sxa merged commit d33bbef into adoptium:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify downloads in static Dockerfiles
3 participants