-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows_repro_build_compare.sh to allow for windows Redist devkit #4022
Conversation
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
This situation also happens to linux https://github.com/adoptium/temurin-build/blob/master/tooling/reproducible/linux_repro_build_compare.sh#L166, which suggests another opportunity for code refactoring and consolidating for different platforms. Creating a reusable function or module will make the logic easier to understand, test and maintain. |
… kit Signed-off-by: Andrew Leonard <[email protected]>
It is the same yes, although the apart from the check for the --use-adoptium-flag, the GCC vs VisualStudio logic is different |
… kit Signed-off-by: Andrew Leonard <[email protected]>
… kit Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4021
Don't check local Windows system UCRT if --use-adoptium-devkit used, as the correct versions will be downloaded.
Grinder test: https://ci.adoptium.net/job/Grinder/11287/