Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows_repro_build_compare.sh to allow for windows Redist devkit #4022

Merged
merged 17 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8c4e1eb
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
6a0446b
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
804f8a4
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
1e80404
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
42b1da7
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
118e506
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
f32dd20
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
42f52ce
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 1, 2024
7a11368
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
8511700
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
4636348
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
fe36492
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
8f1c6bd
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
f53cbb7
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 4, 2024
cfbfac7
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 5, 2024
d5b0bc3
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 5, 2024
b2445ce
Update windows_repro_build_compare.sh to allow for windows Redist dev…
andrew-m-leonard Nov 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sbin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,18 @@ configureDevKitConfigureParameter() {
if [[ "$OSTYPE" == "cygwin" ]] || [[ "$OSTYPE" == "msys" ]]; then
# Windows DevKit, currently only Redist DLLs

# Default to build architecture unless target ARCHITECTURE variable is set
local target_arch="${BUILD_CONFIG[OS_ARCHITECTURE]}"
if [ ${ARCHITECTURE+x} ] && [ -n "${ARCHITECTURE}" ]; then
target_arch="${ARCHITECTURE}"
fi
echo "Target architecture for Windows devkit: ${target_arch}"

# This is TARGET Architecture for the Redist DLLs to use
# ARCHITECTURE is set to the "target" architecture by caller, or defaults to build architecture if not set
local dll_arch
if [[ "${ARCHITECTURE}" == "x86-32" ]]; then
if [[ "${target_arch}" == "x86-32" ]]; then
dll_arch="x86"
elif [[ "${ARCHITECTURE}" == "aarch64" ]]; then
elif [[ "${target_arch}" == "aarch64" ]]; then
dll_arch="arm64"
else
dll_arch="x64"
Expand Down
10 changes: 6 additions & 4 deletions tooling/reproducible/windows_repro_build_compare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -684,10 +684,12 @@ Check_Architecture
echo "---------------------------------------------"
Check_VS_Versions
echo "---------------------------------------------"
Get_SRC_UCRT_Version
echo "---------------------------------------------"
Check_UCRT_Location
echo "---------------------------------------------"
if [[ "${buildArgs}" != *"--use-adoptium-devkit"* ]]; then
Get_SRC_UCRT_Version
echo "---------------------------------------------"
Check_UCRT_Location
echo "---------------------------------------------"
fi
echo "All Validation Checks Passed - Proceeding To Build"
echo "---------------------------------------------"
Check_And_Install_Ant
Expand Down
Loading