Add back failure if no payment method on confirm #229
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to add a payment method by ID on confirm here: #226
I removed validation that there was payment_method_data.
Per review comment on that PR, common sense, and testing with the actual Stripe API, we should still return a 400 error if neither payment_method nor payment_method_data are supplied to the confirm request. So I added that and changed an old test case that seemed to be asserting a behavior unlike what Stripe actually does.
This also addresses another review comment, I was resetting payment_method_types within the confirm handler. Upon testing, this is not what the real Stripe API does, so I removed that recent addition.