Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back failure if no payment method on confirm #229

Closed
wants to merge 1 commit into from
Closed

Add back failure if no payment method on confirm #229

wants to merge 1 commit into from

Commits on Sep 25, 2024

  1. Add back failure if no payment method on confirm 

    I added the ability to add a payment method by ID on confirm here:
adrienverge#226

I removed validation that there was payment_method_data.

Per review comment on that PR, common sense, and testing with the actual Stripe
API, we should still return a 400 error if neither payment_method nor
payment_method_data are supplied to the confirm request. So I added that and
changed an old test case that seemed to be asserting a behavior unlike what
Stripe actually does.

This also addresses another review comment, I was resetting
payment_method_types within the confirm handler. Upon testing, this is not
what the real Stripe API does, so I removed that recent addition.
    Ben Creech committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9faf6de View commit details
    Browse the repository at this point in the history