Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): compatibility with create-react-app #1365

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Dec 10, 2021

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1365 (9e8f82e) into develop (193d457) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1365   +/-   ##
========================================
  Coverage    87.87%   87.87%           
========================================
  Files           55       55           
  Lines         3109     3109           
  Branches        40       40           
========================================
  Hits          2732     2732           
  Misses         356      356           
  Partials        21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193d457...9e8f82e. Read the comment docs.

@davidyuk davidyuk force-pushed the feature/react-compatibility branch 2 times, most recently from 7152ac6 to 4decdce Compare December 10, 2021 07:50
babel.config.js Outdated Show resolved Hide resolved
@marc0olo
Copy link
Contributor

@davidyuk do we need a new release of calldata-lib for this?

@davidyuk
Copy link
Member Author

do we need a new release of calldata-lib for this?

We can merge this as it is now, and switch to the new calldata release before the next SDK release. Without switching to calldata's master, the compatibility issue won't be solved 🤷‍♀️

@subhod-i
Copy link
Collaborator

tests are failing. https://github.com/aeternity/aepp-sdk-js/runs/4962960426?check_suite_focus=true#step:8:149

Crypto and Websocekt APIs are tricky. May work for React app but fails for react-native projects.

@davidyuk davidyuk marked this pull request as ready for review January 27, 2022 12:03
@davidyuk davidyuk marked this pull request as draft January 27, 2022 12:42
@marc0olo
Copy link
Contributor

@davidyuk new release of calldata-lib is out: https://www.npmjs.com/package/@aeternity/aepp-calldata

@davidyuk davidyuk force-pushed the feature/react-compatibility branch 2 times, most recently from 9b0f3dc to 4ca268d Compare January 28, 2022 16:13
@davidyuk
Copy link
Member Author

I'm planning to revisit this after merging #1409 #1408 #1407

@davidyuk davidyuk marked this pull request as ready for review February 12, 2022 12:08
@davidyuk davidyuk merged commit fc50071 into develop Feb 14, 2022
@davidyuk davidyuk deleted the feature/react-compatibility branch February 14, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with argon2-browser Should be compatible with create-react-app out of the box
4 participants