Remove node stream polyfill #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1407 +/- ##
============================================
+ Coverage 68.52% 87.84% +19.32%
============================================
Files 23 54 +31
Lines 1258 3077 +1819
Branches 40 40
============================================
+ Hits 862 2703 +1841
+ Misses 385 353 -32
- Partials 11 21 +10
Continue to review full report at Codecov.
|
davidyuk
force-pushed
the
feature/bs58
branch
from
aa6dee7
to
a3ab08c
Compare
thepiwo
approved these changes
Feb 11, 2022
| @@ -34,9 +34,8 @@ | |||
| "SDK" | |||
| ], | |||
| "dependencies": { | |||
| "@aeternity/aepp-calldata": "^1.1.0", | |||
| "@aeternity/aepp-calldata": "github:aeternity/aepp-calldata-js#a623a44a259cc53e99b1e358ecc7b3f88edcb45c", | |||
There was a problem hiding this comment.
will there be a release with these changes included?
davidyuk
force-pushed
the
feature/bs58
branch
from
a3ab08c
to
dbeae88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to rename
TxBuildHelper.decode/encodeto something more general, but it is not ready yet.The need to switch from
bs58checktobs58is explained in aeternity/aepp-calldata-js#122.bip39 package can be configured to support different languages and this is not up to SDK to decide which of them should be included. Also, it depends on a set of unnecessary crypto libraries that is not easy to get rid of: bitcoinjs/bip39#170. It has a quite simple blockchain-agnostic interface. Our
@aeternity/bip39didn't get updates in 3 years and probably shouldn't be used. So, I'm proposing to make the wallet developer usebip39package by himself and remove it from sdk.