Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well-orderings and Ordinals #1072

Merged
merged 22 commits into from
Feb 23, 2024
Merged

Well-orderings and Ordinals #1072

merged 22 commits into from
Feb 23, 2024

Conversation

LuuBluum
Copy link
Contributor

Defines well-ordered sets, their various properties, as well as a definition of ordinals and some ordinal arithmetic (namely, successor, addition, and multiplication; exponentiation will have to wait).

@felixwellen
Copy link
Collaborator

Please rebase/merge master

@felixwellen felixwellen self-assigned this Jan 22, 2024
Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait (it does help if PRs are shorter)
and thanks for contributing!
Apart from some details which I commented on, I do not know how your PR relates to the literature. @iblech kindly pointed me to this article (not the only one on the topic):
https://arxiv.org/pdf/2301.10696.pdf
which also comes with an agda formalization and an equivalent definition of ordinal. You should add pointers to the literature and comment on the relation of your formalization and others (e.g. if it is independet/inspired/partially copied).

@@ -72,19 +75,20 @@ elim2 Cset f (squash₂ x y p q i j) z =
-- (λ a → elim (λ _ → Cset _ _) (f a))

-- TODO: generalize
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this comment can go.

Cubical/Relation/Binary/Order/Woset/Base.agda Show resolved Hide resolved
@LuuBluum
Copy link
Contributor Author

LuuBluum commented Jan 22, 2024

Sorry for the long wait (it does help if PRs are shorter) and thanks for contributing! Apart from some details which I commented on, I do not know how your PR relates to the literature. @iblech kindly pointed me to this article (not the only one on the topic): https://arxiv.org/pdf/2301.10696.pdf which also comes with an agda formalization and an equivalent definition of ordinal. You should add pointers to the literature and comment on the relation of your formalization and others (e.g. if it is independet/inspired/partially copied).

Oh, to explain that, this is identical to the formalization done in the HoTT book, outside of the bit at the end for ordinal suprema which I did cite my source. Looks like I forgot to mention that at the top of the file; I can rectify that without issue.

@felixwellen
Copy link
Collaborator

Good - that would be great!

@felixwellen
Copy link
Collaborator

Looks all good to me now! -> merging.

@felixwellen felixwellen merged commit 24774d4 into agda:master Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants