Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): downstream promotion #2650

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix(ui): downstream promotion #2650

merged 3 commits into from
Oct 4, 2024
+7 −3

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Oct 4, 2024 •
edited
Loading

Honouring definition of control flow with new promotion template spec

@Marvin9
fix(ui): downstream promotion
5499b0f 
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@Marvin9 Marvin9 requested a review from a team as a code owner October 4, 2024 14:13
@Marvin9 Marvin9 self-assigned this Oct 4, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 075d190
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fffc91cee72200084d5e86
😎 Deploy Preview https://deploy-preview-2650.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 075d190
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/66fffc9170b51b0008f6d6b0
😎 Deploy Preview https://deploy-preview-2650--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.09%. Comparing base (cdec347) to head (075d190).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/api/promote_downstream_v1alpha1.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
+ Coverage   51.04%   51.09%   +0.05%     
==========================================
  Files         282      282              
  Lines       21092    21121      +29     
==========================================
+ Hits        10766    10792      +26     
- Misses       9644     9646       +2     
- Partials      682      683       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this to the v0.9.0 milestone Oct 4, 2024
@krancour krancour self-requested a review October 4, 2024 14:25
@krancour krancour added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit e6b2329 Oct 4, 2024
20 of 21 checks passed
@krancour krancour deleted the Marvin9/fix-control-flow branch October 4, 2024 14:54
github-actions bot pushed a commit that referenced this pull request Oct 4, 2024
@Marvin9 @github-actions
fix(ui): downstream promotion (#2650)
58a7de5 
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
(cherry picked from commit e6b2329)
@akuitybot akuitybot mentioned this pull request Oct 4, 2024
Merged
@akuitybot
Copy link

Successfully created backport PR for release-0.9:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees

@Marvin9 Marvin9

Labels
area/api area/ui backport/release-0.9 priority/high
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Marvin9 @akuitybot @krancour