Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backport release-0.9): fix(ui): downstream promotion #2657

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(backport release-0.9): fix(ui): downstream promotion #2657

merged 1 commit into from
Oct 4, 2024

Conversation

akuitybot
Copy link

Automated backport to release-0.9, triggered by a label in #2650.

@Marvin9 @github-actions
fix(ui): downstream promotion (#2650)
58a7de5 
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
(cherry picked from commit e6b2329)
@akuitybot akuitybot requested a review from a team as a code owner October 4, 2024 14:54
@akuitybot akuitybot requested a review from hiddeco October 4, 2024 14:54
@akuitybot akuitybot mentioned this pull request Oct 4, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.08%. Comparing base (43de1e8) to head (58a7de5).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
internal/api/promote_downstream_v1alpha1.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           release-0.9    #2657   +/-   ##
============================================
  Coverage        51.08%   51.08%           
============================================
  Files              283      283           
  Lines            21168    21170    +2     
============================================
+ Hits             10813    10815    +2     
  Misses            9669     9669           
  Partials           686      686

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge (squash) October 4, 2024 16:32
@krancour krancour merged commit 8b61055 into release-0.9 Oct 4, 2024
19 checks passed
@krancour krancour deleted the backport-2650-to-release-0.9 branch October 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees

@Marvin9 Marvin9

Labels
area/api area/ui priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akuitybot @krancour @Marvin9