Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move builder and pool traits to types #640

Merged
merged 9 commits into from
Mar 30, 2024

chore: fixing PR comments

88a96ae
Select commit
Loading
Failed to load commit list.
Merged

refactor: move builder and pool traits to types #640

chore: fixing PR comments
88a96ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 30, 2024 in 0s

55.22% (-2.08%) compared to 639d1e1

View this Pull Request on Codecov

55.22% (-2.08%) compared to 639d1e1

Details

Codecov Report

Attention: Patch coverage is 37.63103% with 1785 lines in your changes are missing coverage. Please review.

Project coverage is 55.22%. Comparing base (639d1e1) to head (88a96ae).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_sender.rs 0.00% <ø> (ø)
crates/builder/src/server/remote/protos.rs 0.00% <ø> (ø)
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (+8.87%) ⬆️
crates/pool/src/mempool/paymaster.rs 93.62% <100.00%> (+0.48%) ⬆️
crates/pool/src/mempool/pool.rs 95.78% <100.00%> (+<0.01%) ⬆️
crates/pool/src/mempool/reputation.rs 85.25% <ø> (+5.02%) ⬆️
crates/pool/src/server/remote/server.rs 0.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 20.00% <ø> (+7.50%) ⬆️
crates/rpc/src/admin.rs 0.00% <ø> (ø)
crates/rpc/src/eth/events/mod.rs 100.00% <ø> (ø)
... and 60 more

... and 25 files with indirect coverage changes

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 50.64% <16.32%> (-0.68%) ⬇️
dev 0.00% <0.00%> (ø)
pool 65.38% <65.60%> (+0.46%) ⬆️
provider 9.09% <0.77%> (-4.72%) ⬇️
rpc 29.09% <19.12%> (-3.82%) ⬇️
sim 82.85% <38.29%> (-2.32%) ⬇️
tasks ∅ <ø> (∅)
types 66.48% <35.79%> (-7.35%) ⬇️
utils 16.73% <ø> (-0.07%) ⬇️