Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable control by default #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blue-j
Copy link

@blue-j blue-j commented Nov 14, 2024

If control is not enabled, many arguments don't work, including setting the presets necessary to allow PPG signal transmission, for example. I see no problem with enabling control always.

If control is not enabled, many arguments don't work, including setting the presets necessary to allow PPG signal transmission, for example.  I see no problem with enabling control always.
@iPsych
Copy link

iPsych commented Dec 22, 2024

Hello, Thanks for the commit. with your change, streaming stops after about 5 secs after it starts in MacOS, default preset.
muselsl stream -p
Should I change preset for PPG streaming or PPG/ACC/GYRO combination?

@blue-j
Copy link
Author

blue-j commented Dec 22, 2024

Yes, I recommend changing to preset 61, which will work for most people immediately. It would not support the aux electrodes, but I think including them by default for most people is confusing.

I rewrote the preset function actually and could share that code as well. I can't recall if the base code actually works for setting presets.

@iPsych
Copy link

iPsych commented Dec 24, 2024

@blue-j
Strangely, I experience unexpected disconnect issue when EEG+PPG recording with preset 61 in Muse S. Is there any preset explanation for sensors configuration(s)?

@blue-j
Copy link
Author

blue-j commented Dec 27, 2024

I've attached documentation about the presets, in case 61 is not desirable as default:

muse_presets.txt

and here is my fork of the preset function, if it works for you, i would be happy to contribute it.

def select_preset(self, preset="p61"):
    """Set preset for headset configuration
    PRESET 61
    4 CH, 12-bit @ 256 Hz, 52 Hz accelerometer/gyro, 0.1 Hz battery, 32 Hz DRL/REF,
    PPG @ 64 Hz, THERMISTOR @ 16 Hz
    Availability: Muse S 2019, Muse S 2021 (Gen 2)
    """
    try:
        logger.info(f"Selecting preset: {preset}")
        self._write_cmd_str(preset)

    except Exception as e:
        logger.error(
            f"Unexpected error attempting to set preset p{preset}: {e}",
            exc_info=True,
        )

@iPsych
Copy link

iPsych commented Jan 2, 2025

@blue-j Thanks so much! It clearly resolved my questions. I will try with actual device then update : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants