add OpenShift README How To/YAML & .s2i/environment #524
Conversation
|
@coveralls how can the coverage decrease if this adds no new code?! 😸 @cbellone @syjer perhaps you would like to make Coverall less picky and shut up for <1% ? |
README.md
Outdated
| @@ -72,9 +72,36 @@ Importing the Gradle project into Intellij and Eclipse both work. | |||
|
|
|||
| `./gradlew dependencyUpdates` | |||
|
|
|||
|
|
|||
| ## Run on OpenShift | |||
There was a problem hiding this comment.
I would prefer to have this section in another tutorial or wiki page, as we don't have direct reference to other providers on the README.
However, we could add a section "How to run in production", linking the tutorials on the website. WDYT?
There was a problem hiding this comment.
sure, I can move it out of the main README and just link to it. But I'm personally not a huge fan of keeping doc in a separate repo .. IMHO it's easier to have doc as an integral part of a PR together with code changes. I'm therefore going to propose a new docs/ folder here - hope you'll like that.
openshift.yaml
Outdated
| @@ -0,0 +1,196 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
is it possible to move this in a subdirectory, like etc/openshift/ ?
There was a problem hiding this comment.
yes this file can be anywhere you like; I'll move it to etc/openshift/ as suggested.
|
Hi @vorburger, do you have time to apply the requested modification? It would be great to merge this PR! |
|
@cbellone yes! On my list, I'll see if I can make time for this afternoon... |
|
@cbellone I should have a moment today and tomorrow (but not next week) for this - shall we try to wrap it up and get it in? I'll rebase it and address your comments... just noticed that I did this for |
vorburger
force-pushed
the
openshift_1.x-maintenance-squash1
branch
from
c950df7 to
3a95bd6
Compare
actually that would take a little bit of work to adjust - how about first getting this finalized and into |
actually that would take a little bit of work to adjust - how about first getting this finalized and into |
|
1.x-maintenance is the stable branch. We hope to release 2.0 by the end of this year, so we'll have plenty of time to update the tutorial :-) |
I find the doc on the web site is kind of hard to find.. I don't suppose it would help to convince you if I volunteered to "port" (copy/paste) the Cloud Foundry and Heroku doc into Otherwise if you feel strongly about this I guess I could also raise a PR against the What would you like me to do so that we can wrap up this PR? |
|
I think we're OK here. And I also think that it doesn't make sense to duplicate content. Can you raise a PR against the alf.io-website linking the tutorial on the homepage and on the "tutorials" menu? |
I would love to, but I probably won't have time, sorry...
sure, see alfio-event/alf.io-website#7 |
see #403