Skip to content

Commit

Permalink
[Viewer3D] MediaLoader: Send pointSize as is
Browse files Browse the repository at this point in the history
`pointSize` was divided by 100 before being sent to the shader that
rendered the programmable points, and was used as is to set the size of
the "fixed size" points implicitly in the QML.

Now that both cases are handled by the same shader, we do not need to
perform this division here: it will be done directly in the shader (by
opposition, keeping it here would have meant performing a x100
multiplication in the shader for the "fixed size" case).
  • Loading branch information
cbentejac committed Dec 17, 2024
1 parent e3f1e27 commit ebbd000
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion meshroom/ui/qml/Viewer3D/MediaLoader.qml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ import Utils 1.0
var obj = Viewer3DSettings.sfmDataLoaderComp.createObject(sfmDataLoaderEntity, {
"source": source,
"fixedPointSize": Qt.binding(function() { return Viewer3DSettings.fixedPointSize }),
"pointSize": Qt.binding(function() { return 0.01 * Viewer3DSettings.pointSize }),
"pointSize": Qt.binding(function() { return Viewer3DSettings.pointSize }),
"locatorScale": Qt.binding(function() { return Viewer3DSettings.cameraScale }),
"cameraPickingEnabled": Qt.binding(function() { return root.enabled && root.cameraPickingEnabled }),
"resectionId": Qt.binding(function() { return Viewer3DSettings.resectionId }),
Expand Down

0 comments on commit ebbd000

Please sign in to comment.