Fix Qt6-induced issues #2620
Merged
Fix Qt6-induced issues #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fixedPointSize` parameter was used to determine whether the point size was fixed or programmable from the QML (using a `PointSize` render state). With Qt6, this render state is not correctly handled by the RHI and we need to set directly within the shader whether the point size is fixed or not, hence the binding.
`pointSize` was divided by 100 before being sent to the shader that rendered the programmable points, and was used as is to set the size of the "fixed size" points implicitly in the QML. Now that both cases are handled by the same shader, we do not need to perform this division here: it will be done directly in the shader (by opposition, keeping it here would have meant performing a x100 multiplication in the shader for the "fixed size" case).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2620 +/- ##
========================================
Coverage 69.89% 69.89%
========================================
Files 121 121
Lines 7076 7076
========================================
Hits 4946 4946
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
fabiencastan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues that follow the migration to Qt6:
The second issue is also fixed in this related QtAliceVision PR: alicevision/QtAliceVision#81
Features list
fixedPointSizeproperty to the SfMLoader to handle that case in the point cloud-dedicated QtAliceVision shader.