[qmlSfmData] SfmDataEntity: Handle fixed point size in the shader #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of the points in the cloud is now fully handled in the dedicated cloud shader. Prior to this commit, the size of the points in the shader was always determined relatively to the position of the camera. When the `fixedPointSize` option is set, it is now set independently from the camera's position. The `fixedPointSize` variable is added with its corresponding signal and slot.
2 tasks
fabiencastan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the points in the cloud is now fully handled in the dedicated cloud shader. Prior to this commit, the size of the points in the shader was always determined relatively to the position of the camera. When the
fixedPointSizeoption is set, it is now set independently from the camera's position.The
fixedPointSizevariable is added with its corresponding signal and slot.Related Meshroom PR: alicevision/Meshroom#2620