Feat/add realsense gazebo plugin #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Yuri van Warmerdam <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
YuriVanWarmerdam
approved these changes
Nov 20, 2024
rcdt_utilities/sdf/empty.xml.sdf
Outdated
There was a problem hiding this comment.
Change filename to empty.sdf (or perhaps something like empty_sensors.sdf or the like). As discussed, this file being here could be seen as tech debt, but is fine for now, until we can open source more assets.
| <always_on>true</always_on> | ||
| <update_rate>30.0</update_rate> | ||
|
|
||
| <topic>${namespace}/color/image_raw</topic> |
There was a problem hiding this comment.
As discussed, we can consider making this camera/camera/ (or ${namespace}/${namespace} or something like that if we want to confirm more to the way the "real" camera publishes topics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.