feat: Move AnyReceipt and AnyHeader to alloy-consensus-any
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moricho
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
emhane
reviewed
Nov 4, 2024
Comment on lines
138
to
141
| #[doc(alias = "AnyTxReceipt")] | ||
| #[cfg(feature = "serde")] | ||
| pub type AnyTransactionReceipt = | ||
| alloy_serde::WithOtherFields<TransactionReceipt<alloy_consensus::AnyReceiptEnvelope<Log>>>; | ||
| alloy_serde::WithOtherFields<TransactionReceipt<alloy_consensus_any::AnyReceiptEnvelope<Log>>>; |
There was a problem hiding this comment.
make sense to move this receipt too right?
There was a problem hiding this comment.
ah you're right. moved it to alloy-rpc-types-any 🙏
5b5d2ac
zerosnacks
previously approved these changes
Nov 4, 2024
klkvr
requested changes
Nov 11, 2024
moricho
force-pushed
the
concensus-any
branch
from
5b5d2ac
to
ea7e1f3
Compare
klkvr
reviewed
Nov 14, 2024
| use alloy_serde::WithOtherFields; | ||
|
|
||
| /// A catch-all header type for handling headers on multiple networks. | ||
| pub type AnyRpcHeader = alloy_rpc_types_eth::Header<alloy_consensus::AnyHeader>; | ||
|
|
||
| /// A catch-all block type for handling blocks on multiple networks. | ||
| pub type AnyRpcBlock = |
There was a problem hiding this comment.
AnyRpcBlock and AnyRpcTransaction aliases should also be in rpc-types-any
klkvr
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref #1598
Solution
PR Checklist