Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-676: updates rust nightly #537

Merged
merged 8 commits into from
Dec 18, 2024
Merged

STR-676: updates rust nightly #537

merged 8 commits into from
Dec 18, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Dec 13, 2024

Description

Updates rust nightly version.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update
  • Updated or new CI

Blocks 🪨

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-676
STR-630

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.40%. Comparing base (8ae3817) to head (5a99136).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/strata-cli/src/recovery.rs 0.00% 3 Missing ⚠️
bin/prover-client/src/task.rs 0.00% 1 Missing ⚠️
crates/reth/exex/src/cache_db_provider.rs 0.00% 1 Missing ⚠️
crates/state/src/operation.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   56.66%   56.40%   -0.27%     
==========================================
  Files         303      303              
  Lines       30986    30982       -4     
==========================================
- Hits        17559    17475      -84     
- Misses      13427    13507      +80     
Files with missing lines Coverage Δ
bin/strata-cli/src/link.rs 0.00% <ø> (ø)
bin/strata-reth/src/rpc.rs 0.00% <ø> (ø)
crates/btcio/src/rpc/types.rs 51.85% <ø> (-1.24%) ⬇️
crates/state/src/bridge_state.rs 56.96% <ø> (-1.27%) ⬇️
crates/storage/src/cache.rs 76.16% <ø> (ø)
crates/storage/src/exec.rs 47.54% <ø> (ø)
crates/tasks/src/pending_tasks.rs 94.11% <ø> (ø)
crates/test-utils/src/bitcoin.rs 89.47% <100.00%> (ø)
crates/zkvm/adapters/native/src/input.rs 100.00% <ø> (ø)
crates/zkvm/adapters/sp1/src/input.rs 0.00% <ø> (ø)
... and 4 more

... and 45 files with indirect coverage changes

@@ -31,18 +31,21 @@ impl From<SequencerRpcError> for EthApiError {

/// A client to interact with a Sequencer
#[derive(Debug, Clone)]
#[allow(dead_code)] // FIXME: remove this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, my bad :( I removed it already in the upcoming PR (bumping reth to latest)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, once we have it up we can link the PRs by adding the number here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am inclined to put this PR before #542 since it depends on succinct labs bumping their cargo version.

What you think? You can rebase and remove the dead_code lints.

@@ -85,13 +85,15 @@ impl<K: Clone + Eq + Hash, V: Clone> CacheTable<K, V> {

/// Gets the number of elements in the cache.
// TODO replace this with an atomic we update after every op
#[allow(dead_code)] // FIXME: remove this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this stuff, removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, once we have it up we can link the PRs by adding the number here?

@alpenlabs alpenlabs deleted a comment from AaronFeickert Dec 13, 2024
@storopoli storopoli marked this pull request as ready for review December 16, 2024 17:10
@storopoli storopoli requested review from a team as code owners December 16, 2024 17:10
@storopoli storopoli marked this pull request as draft December 16, 2024 17:11
@storopoli storopoli marked this pull request as ready for review December 17, 2024 12:59
delbonis
delbonis previously approved these changes Dec 17, 2024
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure everything builds correctly on nightly-2024-12-12?

@storopoli storopoli force-pushed the STR-676 branch 2 times, most recently from 1d8557d to 0e96d9e Compare December 18, 2024 19:39
@storopoli storopoli changed the title STR-676: updates rust nightly and sets a CI autoupdate cron job STR-676: updates rust nightly Dec 18, 2024
@storopoli storopoli merged commit 807d3ca into main Dec 18, 2024
17 of 18 checks passed
@storopoli storopoli deleted the STR-676 branch December 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants