-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-676: updates rust nightly #537
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 56.66% 56.40% -0.27%
==========================================
Files 303 303
Lines 30986 30982 -4
==========================================
- Hits 17559 17475 -84
- Misses 13427 13507 +80
|
@@ -31,18 +31,21 @@ impl From<SequencerRpcError> for EthApiError { | |||
|
|||
/// A client to interact with a Sequencer | |||
#[derive(Debug, Clone)] | |||
#[allow(dead_code)] // FIXME: remove this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, my bad :( I removed it already in the upcoming PR (bumping reth to latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, once we have it up we can link the PRs by adding the number here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am inclined to put this PR before #542 since it depends on succinct labs bumping their cargo version.
What you think? You can rebase and remove the dead_code
lints.
crates/storage/src/cache.rs
Outdated
@@ -85,13 +85,15 @@ impl<K: Clone + Eq + Hash, V: Clone> CacheTable<K, V> { | |||
|
|||
/// Gets the number of elements in the cache. | |||
// TODO replace this with an atomic we update after every op | |||
#[allow(dead_code)] // FIXME: remove this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this stuff, removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, once we have it up we can link the PRs by adding the number here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure everything builds correctly on nightly-2024-12-12
?
1d8557d
to
0e96d9e
Compare
Description
Updates rust nightly version.
Type of Change
Blocks 🪨
zizmor
and harden CI jobs against malicious attackers #536 since this adds more CI stuff. It would be nice to make sure that the lints passes.The.[email protected]
PR Str-711: bump RETH (and deps) to the latest version. #542Notes to Reviewers
Checklist
Related Issues
STR-676
STR-630