DShot timing improvements #149
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! I will test |
tridge
reviewed
Dec 30, 2024
| LL_RCC_MSI_SetRange(LL_RCC_MSIRANGE_6); | ||
| LL_RCC_MSI_SetCalibTrimming(0); | ||
| LL_RCC_PLL_ConfigDomain_SYS(LL_RCC_PLLSOURCE_MSI, LL_RCC_PLLM_DIV_1, 40, LL_RCC_PLLR_DIV_2); | ||
| LL_RCC_HSI_SetCalibTrimming(16); |
There was a problem hiding this comment.
why 16 for the trimming? maybe this is specific to your board?
There was a problem hiding this comment.
If I remember correctly that value comes from ST's data sheet and is mentioned there as default value. I did not do any trimming specific to my hardware.
Quick-Flash
reviewed
Jan 2, 2025
Mcu/l431/Src/peripherals.c
Outdated
| @@ -71,17 +71,15 @@ void SystemClock_Config(void) | |||
| #endif | |||
|
|
|||
| #else | |||
| LL_RCC_MSI_Enable(); | |||
| LL_RCC_HSI_Enable(); | |||
|
|
|||
| /* Wait till MSI is ready */ | |||
There was a problem hiding this comment.
This comment needs to be updated
Suggested change
| /* Wait till MSI is ready */ | |
| /* Wait till HSI is ready */ |
|
Do you mind merge multi commits into one? |
|
|
@NightHawk32 right |
NightHawk32
force-pushed
the
dshot_timing_improvements
branch
from
198351d to
c86212d
Compare
|
@Huibean done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that the DShot telemetry responses of L431 are sometimes not picked up correctly by betaflight due to 2 reasons:
That's the MSI drifting when heated up witrh a heatgun:
https://github.com/user-attachments/assets/b4a752c0-762f-486b-9145-2abaf7c73def
This is wich HSI:
https://github.com/user-attachments/assets/8c232ff9-8f6b-4ace-a406-ba07d1ed5a5e
This also aligns well with this PR in the bootloader: am32-firmware/AM32-bootloader#35