feat: Port dialogs to AdwDialog

[sungsphinx]

I managed to port most dialogs/windows, except the input remote (and probably the same for the media remote) because the app kept hanging and not responding when trying to show them.

[andyholmes]

Thanks, I'm super backlogged today, but I'll have a look through when I get a chance 👍

[andyholmes]

Looking pretty good, thanks!

The tests in tests/libvalent/ui need to be updated, check for the #define VALENT_TYPE_TEST_SUBJECT at the top of the files.

Also the struct member(s) in valent-window.c/valent-device-preferences-page.c need to be changed from GtkWindow to AdwDialog with:

- g_clear_pointer (&self->preferences, gtk_window_destroy);
+ g_clear_pointer (&self->preferences, adw_dialog_force_close);

Might need to change a few of the above in tests/libvalent/ui/ as well. For now, the only test that needs to pass is the Flatpak (unstable) one, the others will pas when the Fedora image is updated.

Let me know if you need any help!

[andyholmes]

This will have to be changed to '>= 1.5' before merge.

[sungsphinx]

Looking pretty good, thanks!

The tests in tests/libvalent/ui need to be updated, check for the #define VALENT_TYPE_TEST_SUBJECT at the top of the files.

Also the struct member(s) in valent-window.c/valent-device-preferences-page.c need to be changed from GtkWindow to AdwDialog with:

- g_clear_pointer (&self->preferences, gtk_window_destroy);
+ g_clear_pointer (&self->preferences, adw_dialog_force_close);

Might need to change a few of the above in tests/libvalent/ui/ as well. For now, the only test that needs to pass is the Flatpak (unstable) one, the others will pas when the Fedora image is updated.

Let me know if you need any help!

Hi, I am very sorry about this reply being very late, but I need some help with this:

Hopefully I am understanding what the code is supposed to do correctly.

In test-device-preferences-window.c (same for test-preferences-window.c), the code uses gtk_window_present which does not require specifying a parent GtkWidget or window, however adw_dialog_present requires it. The problem I face is that there is no definition to the parent window available, so I am not sure what to do, it might just be that I am kind of tired right now 😅

[andyholmes]

Hi, I am very sorry about this reply being very late, but I need some help with this:

No problem :)

Hopefully I am understanding what the code is supposed to do correctly.

In test-device-preferences-window.c (same for test-preferences-window.c), the code uses gtk_window_present which does not require specifying a parent GtkWidget or window, however adw_dialog_present requires it. The problem I face is that there is no definition to the parent window available, so I am not sure what to do, it might just be that I am kind of tired right now 😅

It looks like that can just be NULL: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/method.Dialog.present.html

If that ends up not working for some reason, you can just do a gtk_window_new() and pass that as the argument.

[sungsphinx]

Hi, I am very sorry about this reply being very late, but I need some help with this:

No problem :)

Hopefully I am understanding what the code is supposed to do correctly.
In test-device-preferences-window.c (same for test-preferences-window.c), the code uses gtk_window_present which does not require specifying a parent GtkWidget or window, however adw_dialog_present requires it. The problem I face is that there is no definition to the parent window available, so I am not sure what to do, it might just be that I am kind of tired right now 😅

It looks like that can just be NULL: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/method.Dialog.present.html

If that ends up not working for some reason, you can just do a gtk_window_new() and pass that as the argument.

Didn't realize you could set it as NULL, oops 😅

[sungsphinx]

Ok... I have no idea what's going on with git 🤨

[andyholmes]

Oh weird, did that happen with a git rebase?

[sungsphinx]

Oh weird, did that happen with a git rebase?

Yea, I am probably going to re-do the branch and open a new PR to clean it up.