Fix file leak in QEMU tracer #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files +10 20 suites +10 25m 37s ⏱️ + 10m 6s For more details on these failures, see this check. Results for commit abc6ada. ± Comparison against base commit fafe677. ♻️ This comment has been updated with latest results. |
|
can you rebase the PR and run the CI again? I'll try to fix the CI soon-ish. |
dnivra
force-pushed
the
fix/fix-file-leak-in-qemu-tracer
branch
from
1132e3d to
509892c
Compare
|
can you please rebase the PR? archr CI is finally fixed after so many years |
dnivra
force-pushed
the
fix/fix-file-leak-in-qemu-tracer
branch
from
509892c to
abc6ada
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mktempis used to get name of a temporary file to which the QEMU output file from taregt is copied to. However, this file is never cleaned up andmktempseems to be deprecated. This PR replacesmktempwith aNamedTemporaryFilethat is cleaned up at the end. All CI runners seem to have failing test cases on master so I'm guessing I didn't break anything with this change.