Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 보호소 프로필 조회 로직을 구현한다. #45

Merged
merged 34 commits into from
Nov 1, 2023
Merged

feat: 보호소 프로필 조회 로직을 구현한다. #45

merged 34 commits into from
Nov 1, 2023

Conversation

bjo6300
Copy link
Member

@bjo6300 bjo6300 commented Oct 31, 2023 •
edited
Loading

⛏ 작업 사항

  • 보호소, 보호소 프로필을 양방향 관계로 구현
  • 보호소 프로필 조회 서비스 구현
  • 보호소 프로필 조회 서비스 테스트 코드 작성
  • 보호소 프로필 조회 컨트롤러 구현
  • 보호소 프로필 조회 컨트롤러 테스트 코드 작성

📝 작업 요약

보호소 프로필 조회 API를 구현했습니다.

💡 관련 이슈

@bjo6300
refactor: shelter와의 관계를 OneToOne으로 수정한다.
f50708d
@bjo6300
feat: shelter에 getter 함수를 구현한다.
155d112
@bjo6300
feat: ShelterImage repository를 생성한다.
f660d0a
@bjo6300
feat: FindShelterDetailResponse를 생성한다.
c9c17fe
@bjo6300
feat: shelter, shelterImage의 BadRequestException을 생성한다.
c847d14
@bjo6300
feat: shelter 프로필 단건 조회 API를 구현한다.
da13050
@bjo6300
test: findShelterImageByShelter 테스트 코드를 작성한다.
c05c5ef
@bjo6300
test: BaseRepositoryTest에 QueryDslConfig를 추가한다.
3f790b0
@bjo6300
Merge branch 'dev' of https://github.com/Anifriends/Anifriends-Backend …
3544e95 
…into feat/#29
@bjo6300
feat: Exception에 도입한 errorCode를 추가한다.
7e15489
@bjo6300
test: findShelterDetail 서비스 테스트 코드를 작성한다.
15e658d
@bjo6300
Merge branch 'dev' of https://github.com/Anifriends/Anifriends-Backend …
65a8ee9 
…into feat/#29
@bjo6300
test: findShelterDetail controller 테스트 코드를 작성한다.
be61705
@bjo6300 bjo6300 linked an issue Oct 31, 2023 that may be closed by this pull request
feat: 보호소 프로필 조회 로직을 구현한다. #29
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Test Results

96 tests  +22   96 ✔️ +22   7s ⏱️ +2s
48 suites +  6     0 💤 ±  0 
48 files   +  6     0 ❌ ±  0 

Results for commit b67eef6. ± Comparison against base commit b4d85e5.

♻️ This comment has been updated with latest results.

pushedrumex
pushedrumex requested changes Oct 31, 2023
View reviewed changes
src/main/java/com/clova/anifriends/domain/shelter/controller/ShelterController.java Outdated Show resolved Hide resolved
src/main/java/com/clova/anifriends/domain/shelter/service/ShelterService.java Show resolved Hide resolved
src/main/java/com/clova/anifriends/domain/shelter/service/ShelterService.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/controller/ShelterControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/controller/ShelterControllerTest.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/service/ShelterServiceTest.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/service/ShelterServiceTest.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/service/ShelterServiceTest.java Outdated Show resolved Hide resolved
src/test/java/com/clova/anifriends/domain/shelter/service/ShelterServiceTest.java Outdated Show resolved Hide resolved
funnysunny08
funnysunny08 previously approved these changes Nov 1, 2023
View reviewed changes
@bjo6300 bjo6300 changed the title feat: 보호소 프로필 조회 API를 구현한다. feat: 보호소 프로필 조회 로직을 구현한다. Nov 1, 2023
pushedrumex
pushedrumex approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@pushedrumex pushedrumex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

hseong3243
hseong3243 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@hseong3243 hseong3243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@bjo6300 bjo6300 merged commit 8e5c27f into dev Nov 1, 2023
6 checks passed
@bjo6300 bjo6300 deleted the feat/#29 branch November 1, 2023 13:38
@bjo6300 bjo6300 mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hseong3243 hseong3243 hseong3243 approved these changes

@pushedrumex pushedrumex pushedrumex approved these changes

@funnysunny08 funnysunny08 Awaiting requested review from funnysunny08 funnysunny08 is a code owner

Assignees

@bjo6300 bjo6300

Labels
✨ Feat
Projects
anifriends-backend-board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 보호소 프로필 조회 로직을 구현한다.
4 participants
@bjo6300 @hseong3243 @funnysunny08 @pushedrumex