Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated boto3 parameter #2443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 8, 2025

SUMMARY

Since we dropped support for the old boto SDK (#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated #2047)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/botocore.py

ADDITIONAL INFORMATION

This comment was marked as outdated.

@tremble tremble force-pushed the boto/final_cleanup branch from eeddf2a to 70f8ba0 Compare January 8, 2025 14:43

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented Jan 9, 2025

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1d394d9055794f1aa3546bfe41318b0c

✔️ ansible-galaxy-importer SUCCESS in 3m 31s
✔️ build-ansible-collection SUCCESS in 10m 38s
✔️ ansible-test-splitter SUCCESS in 4m 08s
integration-amazon.aws-1 FAILURE in 49m 43s
✔️ integration-amazon.aws-2 SUCCESS in 55m 23s
✔️ integration-amazon.aws-3 SUCCESS in 24m 27s
✔️ integration-amazon.aws-4 SUCCESS in 30m 34s
✔️ integration-amazon.aws-5 SUCCESS in 31m 14s
✔️ integration-amazon.aws-6 SUCCESS in 43m 05s
✔️ integration-amazon.aws-7 SUCCESS in 49m 19s
✔️ integration-amazon.aws-8 SUCCESS in 27m 01s
✔️ integration-amazon.aws-9 SUCCESS in 46m 45s
✔️ integration-amazon.aws-10 SUCCESS in 40m 12s
✔️ integration-amazon.aws-11 SUCCESS in 28m 31s
✔️ integration-amazon.aws-12 SUCCESS in 26m 17s
✔️ integration-amazon.aws-13 SUCCESS in 27m 03s
✔️ integration-amazon.aws-14 SUCCESS in 28m 19s
✔️ integration-amazon.aws-15 SUCCESS in 41m 05s
✔️ integration-amazon.aws-16 SUCCESS in 34m 48s
✔️ integration-amazon.aws-17 SUCCESS in 23m 49s
✔️ integration-amazon.aws-18 SUCCESS in 23m 15s
✔️ integration-amazon.aws-19 SUCCESS in 44m 20s
integration-amazon.aws-20 FAILURE in 40m 12s
✔️ integration-amazon.aws-21 SUCCESS in 47m 55s
✔️ integration-amazon.aws-22 SUCCESS in 40m 50s
✔️ integration-community.aws-1 SUCCESS in 28m 16s
✔️ integration-community.aws-2 SUCCESS in 20m 47s
✔️ integration-community.aws-3 SUCCESS in 17m 33s
✔️ integration-community.aws-4 SUCCESS in 28m 07s
✔️ integration-community.aws-5 SUCCESS in 17m 31s
✔️ integration-community.aws-6 SUCCESS in 17m 34s
✔️ integration-community.aws-7 SUCCESS in 25m 53s
✔️ integration-community.aws-8 SUCCESS in 16m 59s
✔️ integration-community.aws-9 SUCCESS in 11m 54s
✔️ integration-community.aws-10 SUCCESS in 17m 42s
✔️ integration-community.aws-11 SUCCESS in 8m 30s
✔️ integration-community.aws-12 SUCCESS in 11m 50s
✔️ integration-community.aws-13 SUCCESS in 9m 14s
✔️ integration-community.aws-14 SUCCESS in 5m 58s
Skipped 8 jobs

@tremble tremble requested a review from abikouo January 10, 2025 07:12
@tremble tremble added this to the 10.0.0 milestone Jan 10, 2025
@tremble tremble added mergeit Merge the PR (SoftwareFactory) do_not_backport This PR should not be backported to stable- branches unless absolutely necessary labels Jan 10, 2025
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/cbb503606bd3493cb820c04d4e35618f

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-amazon.aws-1 SUCCESS in 47m 31s
✔️ integration-amazon.aws-2 SUCCESS in 50m 40s
✔️ integration-amazon.aws-3 SUCCESS in 23m 43s
✔️ integration-amazon.aws-4 SUCCESS in 28m 33s
✔️ integration-amazon.aws-5 SUCCESS in 30m 07s
✔️ integration-amazon.aws-6 SUCCESS in 39m 29s
✔️ integration-amazon.aws-7 SUCCESS in 45m 45s
✔️ integration-amazon.aws-8 SUCCESS in 20m 56s
✔️ integration-amazon.aws-9 SUCCESS in 49m 52s
✔️ integration-amazon.aws-10 SUCCESS in 40m 22s
✔️ integration-amazon.aws-11 SUCCESS in 41m 25s
✔️ integration-amazon.aws-12 SUCCESS in 25m 27s
✔️ integration-amazon.aws-13 SUCCESS in 22m 24s
✔️ integration-amazon.aws-14 SUCCESS in 26m 30s
integration-amazon.aws-15 FAILURE in 45m 05s
✔️ integration-amazon.aws-16 SUCCESS in 34m 01s
✔️ integration-amazon.aws-17 SUCCESS in 23m 19s
✔️ integration-amazon.aws-18 SUCCESS in 26m 24s
✔️ integration-amazon.aws-19 SUCCESS in 35m 40s
✔️ integration-amazon.aws-20 SUCCESS in 41m 18s
✔️ integration-amazon.aws-21 SUCCESS in 28m 29s
✔️ integration-amazon.aws-22 SUCCESS in 45m 14s
✔️ integration-community.aws-1 SUCCESS in 28m 16s
✔️ integration-community.aws-2 SUCCESS in 20m 49s
✔️ integration-community.aws-3 SUCCESS in 16m 57s
✔️ integration-community.aws-4 SUCCESS in 27m 20s
✔️ integration-community.aws-5 SUCCESS in 15m 26s
✔️ integration-community.aws-6 SUCCESS in 16m 03s
✔️ integration-community.aws-7 SUCCESS in 24m 51s
✔️ integration-community.aws-8 SUCCESS in 16m 34s
✔️ integration-community.aws-9 SUCCESS in 11m 44s
✔️ integration-community.aws-10 SUCCESS in 16m 09s
✔️ integration-community.aws-11 SUCCESS in 6m 46s
✔️ integration-community.aws-12 SUCCESS in 11m 48s
✔️ integration-community.aws-13 SUCCESS in 9m 51s
✔️ integration-community.aws-14 SUCCESS in 5m 56s
Skipped 8 jobs

@tremble
Copy link
Contributor Author

tremble commented Jan 10, 2025

regate

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/361dfb66998342c1a1b7ce7f64853c4e

✔️ ansible-galaxy-importer SUCCESS in 11m 26s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 47m 36s
✔️ integration-amazon.aws-2 SUCCESS in 51m 41s
✔️ integration-amazon.aws-3 SUCCESS in 23m 59s
✔️ integration-amazon.aws-4 SUCCESS in 29m 23s
✔️ integration-amazon.aws-5 SUCCESS in 32m 47s
✔️ integration-amazon.aws-6 SUCCESS in 37m 24s
✔️ integration-amazon.aws-7 SUCCESS in 46m 27s
✔️ integration-amazon.aws-8 SUCCESS in 24m 10s
✔️ integration-amazon.aws-9 SUCCESS in 41m 02s
✔️ integration-amazon.aws-10 SUCCESS in 40m 54s
✔️ integration-amazon.aws-11 SUCCESS in 38m 27s
✔️ integration-amazon.aws-12 SUCCESS in 24m 20s
✔️ integration-amazon.aws-13 SUCCESS in 24m 54s
✔️ integration-amazon.aws-14 SUCCESS in 25m 37s
✔️ integration-amazon.aws-15 SUCCESS in 38m 46s
✔️ integration-amazon.aws-16 SUCCESS in 34m 02s
✔️ integration-amazon.aws-17 SUCCESS in 28m 35s
✔️ integration-amazon.aws-18 SUCCESS in 25m 14s
✔️ integration-amazon.aws-19 SUCCESS in 45m 15s
✔️ integration-amazon.aws-20 SUCCESS in 33m 06s
✔️ integration-amazon.aws-21 SUCCESS in 27m 48s
✔️ integration-amazon.aws-22 SUCCESS in 45m 06s
integration-community.aws-1 TIMED_OUT in 1h 00m 28s
✔️ integration-community.aws-2 SUCCESS in 21m 15s
✔️ integration-community.aws-3 SUCCESS in 19m 00s
✔️ integration-community.aws-4 SUCCESS in 25m 35s
✔️ integration-community.aws-5 SUCCESS in 15m 00s
✔️ integration-community.aws-6 SUCCESS in 17m 39s
✔️ integration-community.aws-7 SUCCESS in 26m 03s
✔️ integration-community.aws-8 SUCCESS in 14m 35s
✔️ integration-community.aws-9 SUCCESS in 12m 07s
✔️ integration-community.aws-10 SUCCESS in 15m 39s
✔️ integration-community.aws-11 SUCCESS in 7m 20s
✔️ integration-community.aws-12 SUCCESS in 12m 20s
✔️ integration-community.aws-13 SUCCESS in 9m 16s
✔️ integration-community.aws-14 SUCCESS in 5m 58s
Skipped 8 jobs

@tremble tremble force-pushed the boto/final_cleanup branch from 70f8ba0 to 802c923 Compare January 10, 2025 14:56
@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jan 10, 2025
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/77afc927e88c4dfca2f019a3ebe50837

✔️ ansible-galaxy-importer SUCCESS in 3m 28s
✔️ build-ansible-collection SUCCESS in 10m 16s
✔️ ansible-test-splitter SUCCESS in 4m 00s
✔️ integration-amazon.aws-1 SUCCESS in 46m 10s
✔️ integration-amazon.aws-2 SUCCESS in 55m 56s
✔️ integration-amazon.aws-3 SUCCESS in 25m 20s
✔️ integration-amazon.aws-4 SUCCESS in 29m 47s
✔️ integration-amazon.aws-5 SUCCESS in 30m 37s
✔️ integration-amazon.aws-6 SUCCESS in 42m 21s
✔️ integration-amazon.aws-7 SUCCESS in 48m 33s
✔️ integration-amazon.aws-8 SUCCESS in 24m 30s
✔️ integration-amazon.aws-9 SUCCESS in 44m 05s
✔️ integration-amazon.aws-10 SUCCESS in 38m 09s
integration-amazon.aws-11 FAILURE in 42m 35s
✔️ integration-amazon.aws-12 SUCCESS in 23m 25s
✔️ integration-amazon.aws-13 SUCCESS in 21m 45s
✔️ integration-amazon.aws-14 SUCCESS in 22m 48s
✔️ integration-amazon.aws-15 SUCCESS in 51m 59s
✔️ integration-amazon.aws-16 SUCCESS in 32m 16s
✔️ integration-amazon.aws-17 SUCCESS in 28m 28s
✔️ integration-amazon.aws-18 SUCCESS in 23m 32s
✔️ integration-amazon.aws-19 SUCCESS in 41m 28s
✔️ integration-amazon.aws-20 SUCCESS in 36m 13s
✔️ integration-amazon.aws-21 SUCCESS in 28m 10s
✔️ integration-amazon.aws-22 SUCCESS in 45m 29s
✔️ integration-community.aws-1 SUCCESS in 30m 53s
✔️ integration-community.aws-2 SUCCESS in 21m 59s
✔️ integration-community.aws-3 SUCCESS in 18m 06s
✔️ integration-community.aws-4 SUCCESS in 22m 40s
✔️ integration-community.aws-5 SUCCESS in 15m 42s
✔️ integration-community.aws-6 SUCCESS in 16m 08s
✔️ integration-community.aws-7 SUCCESS in 26m 41s
✔️ integration-community.aws-8 SUCCESS in 12m 43s
✔️ integration-community.aws-9 SUCCESS in 10m 40s
✔️ integration-community.aws-10 SUCCESS in 18m 35s
✔️ integration-community.aws-11 SUCCESS in 6m 26s
integration-community.aws-12 FAILURE in 18m 42s
✔️ integration-community.aws-13 SUCCESS in 8m 32s
✔️ integration-community.aws-14 SUCCESS in 4m 59s
Skipped 8 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do_not_backport This PR should not be backported to stable- branches unless absolutely necessary mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants